You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/07/19 07:05:11 UTC

[GitHub] sohami commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

sohami commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField
URL: https://github.com/apache/drill/pull/1383#discussion_r203605336
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
 ##########
 @@ -792,7 +792,7 @@ private void setupOutputContainerSchema() {
         }
 
         // make sure to project field with children for children to show up in the schema
-        final MaterializedField projected = field.withType(outputType);
+        final MaterializedField projected = field.copy(outputType);
 
 Review comment:
   How about naming functions as `copyWithType` and `copyWithName` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services