[GitHub] [netbeans] sdedic edited a comment on pull request #2679: Properly stop Maven execution from LSP/DAP

[GitBox <gi...@apache.org>]

sdedic edited a comment on pull request #2679:
URL: https://github.com/apache/netbeans/pull/2679#issuecomment-761616746


   Re: earlier creation of the handle. Possibly yes. But still I believe it is more correct (for the LSP) to allow collection of handles from an operation even if the actual process executes asynchronously / creates the handle after the initiator finishes.
   
   Yes, tests should be added.
   
   Q: you seem to suggest testing the collected ProgressHandles in the LSP client; however that's not direct test for the newly added code. Did mean that a functionl test (maven can be cancelled this way) should be done **in addition ** a unit test for the ProgressHandle collection within LSP server ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists