You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lewiszlw (via GitHub)" <gi...@apache.org> on 2023/10/21 07:05:26 UTC
[PR] Not reexport RecordBatch twice [arrow-rs]
lewiszlw opened a new pull request, #4968:
URL: https://github.com/apache/arrow-rs/pull/4968
# Which issue does this PR close?
There are two duplicated reexports with different path. But actually they point to the same source.
After this pr,
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Not reexport RecordBatch twice [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4968:
URL: https://github.com/apache/arrow-rs/pull/4968#issuecomment-1773867546
I think this isn't worth the downstream churn, but thank you for raising this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Not reexport RecordBatch twice [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4968:
URL: https://github.com/apache/arrow-rs/pull/4968#issuecomment-1773728983
This is for backwards compatibility, what is the issue with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Not reexport RecordBatch twice [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4968:
URL: https://github.com/apache/arrow-rs/pull/4968#issuecomment-1773738942
Prior to splitting apart the crate RecordBatch lived under arrow::record_batch, it was then moved to live under arrow_array and therefore re-exported under arrow::array. To avoid breaking downstreams an export at the old path was preserved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Not reexport RecordBatch twice [arrow-rs]
Posted by "lewiszlw (via GitHub)" <gi...@apache.org>.
lewiszlw commented on PR #4968:
URL: https://github.com/apache/arrow-rs/pull/4968#issuecomment-1773844472
Understand, we might add deprecation info, but feel free to close this pr if you don't think we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Not reexport RecordBatch twice [arrow-rs]
Posted by "lewiszlw (via GitHub)" <gi...@apache.org>.
lewiszlw commented on PR #4968:
URL: https://github.com/apache/arrow-rs/pull/4968#issuecomment-1773737218
Just a little confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Not reexport RecordBatch twice [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #4968: Not reexport RecordBatch twice
URL: https://github.com/apache/arrow-rs/pull/4968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org