[GitHub] [iceberg] zhangbutao commented on a diff in pull request #7593: Spark3.4: Throw a friendly exception if table is empty when creating branch

["zhangbutao (via GitHub)" <gi...@apache.org>]

zhangbutao commented on code in PR #7593:
URL: https://github.com/apache/iceberg/pull/7593#discussion_r1193104154


##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##########
@@ -41,6 +41,9 @@ case class CreateOrReplaceBranchExec(
   override protected def run(): Seq[InternalRow] = {
     catalog.loadTable(ident) match {
       case iceberg: SparkTable =>
+        if (iceberg.table.currentSnapshot() == null) {
+          throw new UnsupportedOperationException(s"The Iceberg table: $iceberg" + " has no snapshots")
+        }

Review Comment:
   Not very familiar with design of iceberg snapshots.  I found many annoying code snippet `snapshot == null` , maybe the issue will be gone if every new table has a default snapshot.  Just my immature thought. :)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org