You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/07/12 16:21:19 UTC
[GitHub] [netbeans] matthiasblaesing commented on pull request #3458: lambda expression completion support.
matthiasblaesing commented on PR #3458:
URL: https://github.com/apache/netbeans/pull/3458#issuecomment-1181978856
> > Looks good to me and seems to work ok. Before you merge, please add a license header to the template files. There are already comments i place that can also hold that.
>
> Can we use the shorter variant as described [here](https://www.apache.org/foundation/license-faq.html#Apply-My-Software). Templates are read every time the completion happens.
I doubt this shows up in any measurement. If it is read often enough the read comes straight from cache (apart from disc cache, if I remember correctly freemarker also caches). I'd like to keep the noise down and just use the normal license header we use everywhere else. What is more the template is passed through Freemarker, which kind of defeats the performance argument in my mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists