You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2024/04/04 09:30:39 UTC

Re: [PR] Optionally require alignment when reading IPC, respect alignment when writing [arrow-rs]

tustvold commented on code in PR #5554:
URL: https://github.com/apache/arrow-rs/pull/5554#discussion_r1551324041


##########
arrow-ipc/src/reader.rs:
##########
@@ -495,7 +524,7 @@ impl<'a> ArrayReader<'a> {
 /// and copy over the data if any array data in the input `buf` is not properly aligned.
 /// (Properly aligned array data will remain zero-copy.)
 /// Under the hood it will use [`arrow_data::ArrayDataBuilder::build_aligned`] to construct [`arrow_data::ArrayData`].
-pub fn read_record_batch(

Review Comment:
   Can we keep the doc comment on the non-private version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org