You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/08 02:37:00 UTC
[jira] [Commented] (DRILL-6888) Nested classes in HashAggTemplate
break the plain Java for debugging codegen
[ https://issues.apache.org/jira/browse/DRILL-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713491#comment-16713491 ]
ASF GitHub Bot commented on DRILL-6888:
---------------------------------------
Ben-Zvi opened a new pull request #1569: DRILL-6888: Move nested classes outside HashAggTemplate to allow for plain java compile option
URL: https://github.com/apache/drill/pull/1569
Moved two nested classes (HashAggSpilledPartition and HashAggUpdater) from inside HashAggTemplate into independent files (using "refactor--move").
The only additional change was to pass the allocator to the HashAggUpdater via the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Nested classes in HashAggTemplate break the plain Java for debugging codegen
> ----------------------------------------------------------------------------
>
> Key: DRILL-6888
> URL: https://issues.apache.org/jira/browse/DRILL-6888
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Priority: Minor
>
> The *prefer_plain_java* compile option is useful for debugging of generated code.
> DRILL-6719 ("separate spilling logic for Hash Agg") introduced two nested classes into the HashAggTemplate class. However those nested classes cause the prefer_plain_java compile option to fail when compiling the generated code, like:
> {code:java}
> Error: SYSTEM ERROR: CompileException: File '/tmp/janino5709636998794673307.java', Line 36, Column 35: No applicable constructor/method found for actual parameters "org.apache.drill.exec.test.generated.HashAggregatorGen11$HashAggSpilledPartition"; candidates are: "protected org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate$BatchHolder org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate.injectMembers(org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate$BatchHolder)"
> {code}
> +The proposed fix+: Move those nested classes outside HashAgTemplate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)