[GitHub] [incubator-apisix] moonming commented on issue #1407: bugfix: throw error meg when call admin API to enable mqtt plugin but `stream_proxy` is disabled.

[GitBox <gi...@apache.org>]

moonming commented on issue #1407: bugfix: throw error meg when call admin API to enable mqtt plugin but `stream_proxy` is disabled.
URL: https://github.com/apache/incubator-apisix/pull/1407#issuecomment-610148808
 
 
   lgtm
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   YuanSheng Wang <no...@github.com> 于2020年4月7日周二 上午11:08写道：
   
   > *@membphis* commented on this pull request.
   > ------------------------------
   >
   > In t/admin/stream-routes.t
   > <https://github.com/apache/incubator-apisix/pull/1407#discussion_r404509397>
   > :
   >
   > > +my $apisix_home = $ENV{APISIX_HOME} || cwd();
   > +
   > +sub read_file($) {
   > +    my $infile = shift;
   > +    open my $in, "$apisix_home/$infile"
   > +        or die "cannot open $infile for reading: $!";
   > +    my $data = do { local $/; <$in> };
   > +    close $in;
   > +    $data;
   > +}
   > +
   > +my $yaml_config = read_file("conf/config.yaml");
   > +$yaml_config =~ s/node_listen: 9080/node_listen: 1984/;
   > +$yaml_config =~ s/enable_heartbeat: true/enable_heartbeat: false/;
   > +$yaml_config =~ s/  # stream_proxy:/  stream_proxy:\n    tcp:\n      - 9100/;
   > +$yaml_config =~ s/admin_key:/admin_key_useless:/;
   >
   > how about disable_admin_key ?
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-apisix/pull/1407#discussion_r404509397>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBKZVNG4LAZLTZ27CUHTRLKKJ5ANCNFSM4MCWX76A>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services