You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/02 17:44:41 UTC

[GitHub] [superset] rusackas commented on pull request #19906: fix: "fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode"

rusackas commented on PR #19906:
URL: https://github.com/apache/superset/pull/19906#issuecomment-1115167668

   For added context, this PR is reverting the prior fix because it led to a new issue, where results from valid queries were not being displayed properly. To repro:
   
   1) Run sql query with 100 rows limit
   2) Check query history and observe that there is no "view result" button
   3) Run the query again with different row limit, and see that the result button is now shown
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org