You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/23 02:41:10 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request, #273: [FLINK-29070] Provide a option to force the removal of the normalize node when streaming read
JingsongLi opened a new pull request, #273:
URL: https://github.com/apache/flink-table-store/pull/273
There are many jobs that do not require a downstream normalize node, and the key is that the node has a very large cost.
Introduce a option:
Whether to force the removal of the normalize node when streaming read. Note: This is dangerous and is likely to cause data errors if downstream is used to calculate aggregation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #273: [FLINK-29070] Provide a option to force the removal of the normalize node when streaming read
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #273:
URL: https://github.com/apache/flink-table-store/pull/273#discussion_r952105130
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java:
##########
@@ -120,6 +121,10 @@ public ChangelogMode getChangelogMode() {
} else if (table instanceof ChangelogWithKeyFileStoreTable) {
Review Comment:
Nit: in the long run, I think we can simplify the configuration to some extent, e.g., depend on `ChangelogProducer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #273: [FLINK-29070] Provide a option to force the removal of the normalize node when streaming read
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #273:
URL: https://github.com/apache/flink-table-store/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org