You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "pdxcodemonkey (GitHub)" <gi...@apache.org> on 2018/09/12 20:04:00 UTC

[GitHub] [geode-native] pdxcodemonkey opened pull request #351: GEODE-5626: Fix crash in register all keys

- Refactor Cluster class so we can apply locators separately.
- Clean up server directories at test startup.
- Add test cases for caching proxy and proxy regions with getInitialValues set to true
- remove extraneous comment and empty doc comments
- throw exception if gfsh exits non-zero
- use relative path when deleting server directory


[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] moleske commented on pull request #351: GEODE-5626: Fix crash in register all keys

Posted by "moleske (GitHub)" <gi...@apache.org>.

`pf` isn't a great name for such otherwise beautiful new code.

[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #351: GEODE-5626: Fix crash in register all keys

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.

Too many `*` here. This is not a documentation block, just a comment block.

[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey closed pull request #351: GEODE-5626: Fix crash in register all keys

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.

[ pull request closed by pdxcodemonkey ]

[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #351: GEODE-5626: Fix crash in register all keys

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.

Renamed all instances `poolFactory`

[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org