[jira] [Commented] (HIVE-25473) QOutProcessor should mask only match

["László Bodor (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403075#comment-17403075 ] 

László Bodor commented on HIVE-25473:
-------------------------------------

do you agree with the idea [~kgyrtkirk]?

> QOutProcessor should mask only match
> ------------------------------------
>
>                 Key: HIVE-25473
>                 URL: https://issues.apache.org/jira/browse/HIVE-25473
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>
> Currently is QOutProcessor finds a match it mask the whole line:
> {code}
>       for (String word : maskIfContains) {
>         if (result.line.contains(word)) {
>           result.line = MASK_PATTERN;
>         }
>       }
> {code}
> context PR conversation is [here|https://github.com/apache/hive/pull/2478/commits/5a2ea84e59204f0fe3531b951485c7bbfcd8499b#r682339546]
> this can lead to masking probably useful info, e.g. in HIVE-25331 a managed location uri appeared, and already existing info has been masked out, so from:
> {code}
> newdb		location/in/test		hive_test_user	USER			
> {code}
> to:
> {code}
> #### A masked pattern was here ####
> {code}
> this is tricky, because the original line contained the location, but it was empty I guess, so look at it as:
> {code}
> newdb		location/in/test  {location_is_here_but_it_is_empty}		hive_test_user	USER			
> {code}
> in my opinion this should change to:
> {code}
> newdb		location/in/test  #### A masked pattern was here ####		hive_test_user	USER			
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)