You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by chunrong lai <ch...@gmail.com> on 2008/09/04 17:06:02 UTC
Re: svn commit: r691476 - in /harmony/enhanced/classlib/trunk/modules/concurrent: build.xml make/hyproperties.xml
hi, Nathan:
I see the commit breaks some classlib test, include ReentrantLockTest,
AbstractQueuedSynchronizerTest, ExecutorsTest and ScheduledExecutorTest, as
reported in the integrity testing. Do we need a check?
One can reproduce the error in the directory of working_classlib: ant
-Dtest.jre.home=...\drlvm\...\jdk\jre -Dtest.case=ReentrantLockTest test.
Thanks.
On 9/3/08, ndbeyer@apache.org <nd...@apache.org> wrote:
>
> Author: ndbeyer
> Date: Tue Sep 2 19:44:27 2008
> New Revision: 691476
>
> URL: http://svn.apache.org/viewvc?rev=691476&view=rev
> Log:
> fix test targets to execute tests in 'standard' folder
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/concurrent/build.xml
> harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml
>
> Modified: harmony/enhanced/classlib/trunk/modules/concurrent/build.xml
> URL:
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/concurrent/build.xml?rev=691476&r1=691475&r2=691476&view=diff
>
> ==============================================================================
> --- harmony/enhanced/classlib/trunk/modules/concurrent/build.xml (original)
> +++ harmony/enhanced/classlib/trunk/modules/concurrent/build.xml Tue Sep 2
> 19:44:27 2008
> @@ -61,7 +61,7 @@
> </target>
>
> <!-- internal target for local and global test run sequence -->
> - <target name="-test-module" depends="prepare-exclude" />
> + <target name="-test-module" depends="build, compile-tests,
> prepare-exclude, run-tests" />
>
> <target name="clean">
> <delete
> file="${hy.jdk}/jre/lib/boot/${hy.concurrent.packaging.jarname}.jar" />
> @@ -77,8 +77,8 @@
>
> <mkdir dir="${hy.build}" />
>
> - <javac sourcepath=""
> - destdir="${hy.build}"
> + <javac destdir="${hy.build}"
> + sourcepath=""
> compiler="${hy.javac.compiler}"
> memoryMaximumSize="${hy.javac.maxmem}"
> source="${hy.javac.source}"
> @@ -125,8 +125,7 @@
>
> <mkdir dir="${hy.concurrent.bin.test}" />
>
> - <javac srcdir="${hy.concurrent.src.test.java}"
> - destdir="${hy.concurrent.bin.test}"
> + <javac destdir="${hy.concurrent.bin.test}"
> sourcepath=""
> compiler="${hy.javac.compiler}"
> memoryMaximumSize="${hy.javac.maxmem}"
> @@ -190,6 +189,13 @@
> <include name="**/*Test.java" unless="test.case" />
> <excludesfile name="${concurrent.exclude.file}"
> unless="test.case" />
> </fileset>
> + <fileset dir="${hy.concurrent.src.test.standard}">
> + <!-- if ${test.case} -->
> + <include name="${converted.tc}" if="test.case" />
> + <!-- unless ${test.case} -->
> + <include name="**/*Test.java" unless="test.case" />
> + <excludesfile name="${concurrent.exclude.file}"
> unless="test.case" />
> + </fileset>
> </batchtest>
> </junit>
> <antcall target="touch-failures-file" />
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml
> URL:
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml?rev=691476&r1=691475&r2=691476&view=diff
>
> ==============================================================================
> ---
> harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml
> (original)
> +++
> harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml Tue
> Sep 2 19:44:27 2008
> @@ -21,10 +21,12 @@
> <src>
> <main>
> <java location="src/main/java" />
> + <standard location="standard/src/main/java" />
> <resources location="src/main/resources" />
> </main>
> <test>
> <java location="src/test/java" />
> + <standard location="standard/src/test/java" />
> <resources location="src/test/resources" />
> </test>
> </src>
>
>
>
Re: svn commit: r691476 - in /harmony/enhanced/classlib/trunk/modules/concurrent: build.xml make/hyproperties.xml
Posted by Nathan Beyer <nd...@apache.org>.
I'd give these tests the benefit of doubt for the moment and assume if
they're failing, then perhaps something's not quite right in Harmony.
These tests are straight from the concurrency developer's themselves.
I haven't had a chance to run the tests against the RI, but that's
probably the next thing to do to make sure these are good tests.
-Nathan
On Thu, Sep 4, 2008 at 10:16 PM, chunrong lai <ch...@gmail.com> wrote:
> Thanks. I see it is OK to just exclude the tests.
> On the other hand the failure looks not simply from the tests because
> different testcases break in different platforms (but all Uncaught exception
> in similar categories). I just wonder if it exposes some issues in exception
> handling/testing.
>
> public void threadShouldThrow() {
> threadFailed = true;
> fail("should throw exception");
> }
> public void run() {
> try {
> lock.lockInterruptibly();
> threadShouldThrow();
> } catch(InterruptedException success){}
> }
>
> Sorry or the confusion.
>
> On 9/5/08, Nathan Beyer <nd...@apache.org> wrote:
>>
>> I mentioned it in another thread, so it may have gone unnoticed.
>>
>> On Thu, Sep 4, 2008 at 10:38 AM, Tim Ellison <t....@gmail.com>
>> wrote:
>> > chunrong lai wrote:
>> >> hi, Nathan:
>> >> I see the commit breaks some classlib test, include
>> ReentrantLockTest,
>> >> AbstractQueuedSynchronizerTest, ExecutorsTest and ScheduledExecutorTest,
>> as
>> >> reported in the integrity testing. Do we need a check?
>> >> One can reproduce the error in the directory of working_classlib: ant
>> >> -Dtest.jre.home=...\drlvm\...\jdk\jre -Dtest.case=ReentrantLockTest
>> test.
>> >> Thanks.
>> >
>> > In Nathan's defense, he didn't break anything but simply enabled tests
>> > that we should have been running. Maybe these need JIRAs and adding to
>> > the exclude list until somebody steps forward to address them.
>> >
>> > Regards,
>> > Tim
>> >
>> >
>>
>
Re: svn commit: r691476 - in /harmony/enhanced/classlib/trunk/modules/concurrent: build.xml make/hyproperties.xml
Posted by chunrong lai <ch...@gmail.com>.
Thanks. I see it is OK to just exclude the tests.
On the other hand the failure looks not simply from the tests because
different testcases break in different platforms (but all Uncaught exception
in similar categories). I just wonder if it exposes some issues in exception
handling/testing.
public void threadShouldThrow() {
threadFailed = true;
fail("should throw exception");
}
public void run() {
try {
lock.lockInterruptibly();
threadShouldThrow();
} catch(InterruptedException success){}
}
Sorry or the confusion.
On 9/5/08, Nathan Beyer <nd...@apache.org> wrote:
>
> I mentioned it in another thread, so it may have gone unnoticed.
>
> On Thu, Sep 4, 2008 at 10:38 AM, Tim Ellison <t....@gmail.com>
> wrote:
> > chunrong lai wrote:
> >> hi, Nathan:
> >> I see the commit breaks some classlib test, include
> ReentrantLockTest,
> >> AbstractQueuedSynchronizerTest, ExecutorsTest and ScheduledExecutorTest,
> as
> >> reported in the integrity testing. Do we need a check?
> >> One can reproduce the error in the directory of working_classlib: ant
> >> -Dtest.jre.home=...\drlvm\...\jdk\jre -Dtest.case=ReentrantLockTest
> test.
> >> Thanks.
> >
> > In Nathan's defense, he didn't break anything but simply enabled tests
> > that we should have been running. Maybe these need JIRAs and adding to
> > the exclude list until somebody steps forward to address them.
> >
> > Regards,
> > Tim
> >
> >
>
Re: svn commit: r691476 - in /harmony/enhanced/classlib/trunk/modules/concurrent: build.xml make/hyproperties.xml
Posted by Nathan Beyer <nd...@apache.org>.
I mentioned it in another thread, so it may have gone unnoticed.
On Thu, Sep 4, 2008 at 10:38 AM, Tim Ellison <t....@gmail.com> wrote:
> chunrong lai wrote:
>> hi, Nathan:
>> I see the commit breaks some classlib test, include ReentrantLockTest,
>> AbstractQueuedSynchronizerTest, ExecutorsTest and ScheduledExecutorTest, as
>> reported in the integrity testing. Do we need a check?
>> One can reproduce the error in the directory of working_classlib: ant
>> -Dtest.jre.home=...\drlvm\...\jdk\jre -Dtest.case=ReentrantLockTest test.
>> Thanks.
>
> In Nathan's defense, he didn't break anything but simply enabled tests
> that we should have been running. Maybe these need JIRAs and adding to
> the exclude list until somebody steps forward to address them.
>
> Regards,
> Tim
>
>
Re: svn commit: r691476 - in /harmony/enhanced/classlib/trunk/modules/concurrent: build.xml make/hyproperties.xml
Posted by chunrong lai <ch...@gmail.com>.
Thanks. I see that the failures look OS dependent. For example, there seems
to be more failures in windows32 than Linux32(Fedora7).
I just reproduced the failures in windows32 and Linux32(Fedora7) with the
commit, the error messages are like
compile-tests:
[echo] Compiling CONCURRENT tests
prepare-exclude:
[concat] No existing files and no nested text, doing nothing
run-tests:
[junit] Running ExecutorsTest
[junit] Uncaught exception in pool-12-thread-1:
[junit] junit.framework.AssertionFailedError
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at junit.framework.Assert.assertTrue(Assert.java:20)
[junit] at junit.framework.Assert.assertTrue(Assert.java:27)
[junit] at JSR166TestCase.threadAssertTrue(JSR166TestCase.java:218)
[junit] at ExecutorsTest$2.run(ExecutorsTest.java:405)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:643)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:668)
[junit] at
java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:575)
[junit] at
java.security.AccessController.doPrivilegedImpl(AccessController.java:171)
[junit] at
java.security.AccessController.doPrivileged(AccessController.java:64)
[junit] at
java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:572)
[junit] at java.lang.Thread.run(Thread.java:670)
[junit] Tests run: 32, Failures: 1, Errors: 0, Time elapsed: 2.258 sec
[junit] Test ExecutorsTest FAILED
On 9/4/08, Tim Ellison <t....@gmail.com> wrote:
>
> chunrong lai wrote:
> > hi, Nathan:
> > I see the commit breaks some classlib test, include
> ReentrantLockTest,
> > AbstractQueuedSynchronizerTest, ExecutorsTest and ScheduledExecutorTest,
> as
> > reported in the integrity testing. Do we need a check?
> > One can reproduce the error in the directory of working_classlib: ant
> > -Dtest.jre.home=...\drlvm\...\jdk\jre -Dtest.case=ReentrantLockTest test.
> > Thanks.
>
> In Nathan's defense, he didn't break anything but simply enabled tests
> that we should have been running. Maybe these need JIRAs and adding to
> the exclude list until somebody steps forward to address them.
>
> Regards,
> Tim
>
>
Re: svn commit: r691476 - in /harmony/enhanced/classlib/trunk/modules/concurrent:
build.xml make/hyproperties.xml
Posted by Tim Ellison <t....@gmail.com>.
chunrong lai wrote:
> hi, Nathan:
> I see the commit breaks some classlib test, include ReentrantLockTest,
> AbstractQueuedSynchronizerTest, ExecutorsTest and ScheduledExecutorTest, as
> reported in the integrity testing. Do we need a check?
> One can reproduce the error in the directory of working_classlib: ant
> -Dtest.jre.home=...\drlvm\...\jdk\jre -Dtest.case=ReentrantLockTest test.
> Thanks.
In Nathan's defense, he didn't break anything but simply enabled tests
that we should have been running. Maybe these need JIRAs and adding to
the exclude list until somebody steps forward to address them.
Regards,
Tim