[GitHub] [hudi] danny0405 commented on a diff in pull request #8689: [HUDI-6197] Fix use CONTAINER_ID to judge hudi is running in yarn con…

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8689:
URL: https://github.com/apache/hudi/pull/8689#discussion_r1191858073


##########
hudi-common/src/main/java/org/apache/hudi/common/util/FileIOUtils.java:
##########
@@ -226,16 +226,17 @@ public static String[] getConfiguredLocalDirs() {
 
   private static boolean isRunningInYarnContainer() {
     // These environment variables are set by YARN.
-    return System.getenv("CONTAINER_ID") != null;
+    return System.getenv("CONTAINER_ID") != null
+        && System.getenv("LOCAL_DIRS") != null;

Review Comment:
   What's nuances, the logic seems not change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org