You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Adrian Corcoran (JIRA)" <ji...@apache.org> on 2008/10/13 12:00:44 UTC
[jira] Created: (CXF-1859) mtom-enabled property case sensitive
mtom-enabled property case sensitive
------------------------------------
Key: CXF-1859
URL: https://issues.apache.org/jira/browse/CXF-1859
Project: CXF
Issue Type: Bug
Components: Configuration
Affects Versions: 2.0.8
Environment: jdk1.5
Reporter: Adrian Corcoran
Priority: Minor
Setting of jax-ws endpoint property mtom-enabled is case sensitive - setting value to 'TRUE' rather than 'true' will not enable mtom.
The root of this problem is in MessageUtils.
public static boolean isTrue(Object value) {
if (Boolean.TRUE.equals(value) || "true".equals(value)) {
return true;
}
return false;
}
This should obviously be
public static boolean isTrue(Object value) {
return Boolean.valueOf(value.toString());
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1859) mtom-enabled property case sensitive
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639397#action_12639397 ]
Benson Margulies commented on CXF-1859:
---------------------------------------
I think this is fine as it is. The policy about tests does not call for unit tests for complete trivia. If you were felling really frisky, you could find and mtom test in systests and add a case for this, but testing the MessageUtils just for this strikes me as silly.
> mtom-enabled property case sensitive
> ------------------------------------
>
> Key: CXF-1859
> URL: https://issues.apache.org/jira/browse/CXF-1859
> Project: CXF
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.8
> Environment: jdk1.5
> Reporter: Adrian Corcoran
> Priority: Minor
> Attachments: MessageUtils.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Setting of jax-ws endpoint property mtom-enabled is case sensitive - setting value to 'TRUE' rather than 'true' will not enable mtom.
> The root of this problem is in MessageUtils.
> public static boolean isTrue(Object value) {
> if (Boolean.TRUE.equals(value) || "true".equals(value)) {
> return true;
> }
>
> return false;
> }
> This should obviously be
> public static boolean isTrue(Object value) {
> return Boolean.valueOf(value.toString());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1859) mtom-enabled property case sensitive
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639255#action_12639255 ]
Benson Margulies commented on CXF-1859:
---------------------------------------
Would you care to post up a patch? Not that it's hard for one of us to fix, just that I'm always looking for opportunities to lure in new contributors.
> mtom-enabled property case sensitive
> ------------------------------------
>
> Key: CXF-1859
> URL: https://issues.apache.org/jira/browse/CXF-1859
> Project: CXF
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.8
> Environment: jdk1.5
> Reporter: Adrian Corcoran
> Priority: Minor
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Setting of jax-ws endpoint property mtom-enabled is case sensitive - setting value to 'TRUE' rather than 'true' will not enable mtom.
> The root of this problem is in MessageUtils.
> public static boolean isTrue(Object value) {
> if (Boolean.TRUE.equals(value) || "true".equals(value)) {
> return true;
> }
>
> return false;
> }
> This should obviously be
> public static boolean isTrue(Object value) {
> return Boolean.valueOf(value.toString());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-1859) mtom-enabled property case sensitive
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies resolved CXF-1859.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.2
Patch applied. Thanks.
> mtom-enabled property case sensitive
> ------------------------------------
>
> Key: CXF-1859
> URL: https://issues.apache.org/jira/browse/CXF-1859
> Project: CXF
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.8
> Environment: jdk1.5
> Reporter: Adrian Corcoran
> Priority: Minor
> Fix For: 2.2
>
> Attachments: MessageUtils.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Setting of jax-ws endpoint property mtom-enabled is case sensitive - setting value to 'TRUE' rather than 'true' will not enable mtom.
> The root of this problem is in MessageUtils.
> public static boolean isTrue(Object value) {
> if (Boolean.TRUE.equals(value) || "true".equals(value)) {
> return true;
> }
>
> return false;
> }
> This should obviously be
> public static boolean isTrue(Object value) {
> return Boolean.valueOf(value.toString());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-1859) mtom-enabled property case sensitive
Posted by "Michael Masters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Masters updated CXF-1859:
---------------------------------
Attachment: MessageUtils.patch
I changed the fix to use equalsIgnoreCase() because the suggested implementation would allow "yes". I wasn't sure if this was acceptable. I ran all the tests and they passed. I was going to write a unit test for this, but there wasn't a MessageUtilsTest.java file. What is the testing policy? I was going to create the test class, but I wanted to ask before doing so.
I've never submitted a patch before, so any input would be awesome.
cheers,
Mike
> mtom-enabled property case sensitive
> ------------------------------------
>
> Key: CXF-1859
> URL: https://issues.apache.org/jira/browse/CXF-1859
> Project: CXF
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.8
> Environment: jdk1.5
> Reporter: Adrian Corcoran
> Priority: Minor
> Attachments: MessageUtils.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Setting of jax-ws endpoint property mtom-enabled is case sensitive - setting value to 'TRUE' rather than 'true' will not enable mtom.
> The root of this problem is in MessageUtils.
> public static boolean isTrue(Object value) {
> if (Boolean.TRUE.equals(value) || "true".equals(value)) {
> return true;
> }
>
> return false;
> }
> This should obviously be
> public static boolean isTrue(Object value) {
> return Boolean.valueOf(value.toString());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.