You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/14 02:50:24 UTC
[GitHub] [spark] yutoacts opened a new pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
yutoacts opened a new pull request #35838:
URL: https://github.com/apache/spark/pull/35838
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add git ignore entries for files created by ANTLR.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To avoid developers from accidentally adding those files when working on parser/lexer.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
To make sure those files are ignored by `git status` when they exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #35838:
URL: https://github.com/apache/spark/pull/35838#discussion_r827654849
##########
File path: .gitignore
##########
@@ -117,3 +117,7 @@ spark-warehouse/
# For Node.js
node_modules
+
+# For Antlr
+sql/catalyst/gen/
+*.tokens
Review comment:
All the entries we need to add are:
```
sql/catalyst/gen/
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/gen/
```
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yutoacts commented on pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
yutoacts commented on pull request #35838:
URL: https://github.com/apache/spark/pull/35838#issuecomment-1067607714
@HyukjinKwon Thanks for the review. I'm still looking for what exactly generated those files, but it happened when I edited `SqlBaseParser.g4` and ran related tests by using IntelliJ scala test. I think building/testing with IntelliJ ends up generating some unnecessary files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yutoacts commented on pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
yutoacts commented on pull request #35838:
URL: https://github.com/apache/spark/pull/35838#issuecomment-1069904986
> > or switch to master branch by git checkout
>
> ~More precisely, in case you switch from a revision <= [dfff8d8](https://github.com/apache/spark/commit/dfff8d8cd0e747a261bf74374a5797e7c2acaebb) to a revision >= [b71d6d0](https://github.com/apache/spark/commit/b71d6d07bb84300b343b9a487049d2566d26a5e9), IDEA seems to generate them.~
>
> EDIT: Now I can't reproduce that with the way explained above. I don't know the precise mechanism of this phenomenon but as far as I know, these files can be generated by IDEA.
>
> ```
> sql/catalyst/gen/
> sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.tokens
> sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/gen/
> ```
@sarutak Thanks a lot for your help!
In my environment, switching the branch from one with revision <= https://github.com/apache/spark/commit/dfff8d8cd0e747a261bf74374a5797e7c2acaebb to another with >= https://github.com/apache/spark/commit/b71d6d07bb84300b343b9a487049d2566d26a5e9 produce the files below (though SqlBaseLexer.tokens is not always generated).
```
sql/catalyst/gen/
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.tokens
```
@HyukjinKwon I think it's safe to add those three lines @sarutak mentioned to git ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #35838:
URL: https://github.com/apache/spark/pull/35838#issuecomment-1068792984
> or switch to master branch by git checkout
~~More precisely, in case you switch from a revision <= dfff8d8cd0e747a261bf74374a5797 to a revision >= b71d6d07bb84300b343b9a487049d25, IDEA seems to generate them.~~
EDIT:
Now I can't reproduce that with the way explained above.
I don't know the precise mechanism of this phenomenon but as far as I know, these files can be generated by IDEA.
```
sql/catalyst/gen/
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.tokens
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/gen/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #35838:
URL: https://github.com/apache/spark/pull/35838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #35838:
URL: https://github.com/apache/spark/pull/35838#issuecomment-1068739436
@yutoacts I found the way to reproduce that.
If you newly import the `master` repository into IDEA, or switch to `master` branch by `git checkout`, the `gen` directory will be generated by IDEA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #35838:
URL: https://github.com/apache/spark/pull/35838#issuecomment-1068792984
> or switch to master branch by git checkout
More precisely, in case you switch from a revision <= dfff8d8cd0e747a261bf74374a5797 to a revision >= b71d6d07bb84300b343b9a487049d25, IDEA seems to generate them.
EDIT:
Now I can't reproduce that with the way explained above.
I don't know the precise mechanism of this phenomenon but as far as I know, these files can be generated by IDEA.
```
sql/catalyst/gen/
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.tokens
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/gen/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35838:
URL: https://github.com/apache/spark/pull/35838#issuecomment-1066287207
qq: mind explaining how these are generated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yutoacts commented on a change in pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
yutoacts commented on a change in pull request #35838:
URL: https://github.com/apache/spark/pull/35838#discussion_r828704711
##########
File path: .gitignore
##########
@@ -117,3 +117,7 @@ spark-warehouse/
# For Node.js
node_modules
+
+# For Antlr
+sql/catalyst/gen/
+*.tokens
Review comment:
In my case, `sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/gen/` is never generated but `sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.tokens` is instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #35838:
URL: https://github.com/apache/spark/pull/35838#issuecomment-1068792984
> or switch to master branch by git checkout
More precisely, in case you switch from a revision <= dfff8d8cd0e747a261bf74374a5797 to a revision >= b71d6d07bb84300b343b9a487049d25, IDEA seems to generate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org