You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/05 20:01:34 UTC
[GitHub] [druid] Fokko opened a new pull request #9128: Small fixes from
#7701
Fokko opened a new pull request #9128: Small fixes from #7701
URL: https://github.com/apache/druid/pull/9128
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
Fixes small issues from https://github.com/apache/druid/pull/7701
Fixes #XXXX.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
Fixes small issues with open resources, which we're not closed.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] Fokko closed pull request #9128: Small fixes from #7701
Posted by GitBox <gi...@apache.org>.
Fokko closed pull request #9128: Small fixes from #7701
URL: https://github.com/apache/druid/pull/9128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #9128:
Small fixes from #7701
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #9128: Small fixes from #7701
URL: https://github.com/apache/druid/pull/9128#discussion_r363932857
##########
File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/IndexGeneratorJob.java
##########
@@ -114,13 +114,13 @@
final Path descriptorInfoDir = config.makeDescriptorInfoDir();
- try {
- FileSystem fs = descriptorInfoDir.getFileSystem(conf);
-
+ try (FileSystem fs = descriptorInfoDir.getFileSystem(conf)) {
Review comment:
Hi @Fokko, would you elaborate more on this change? Seems like `Path.getFileSystem()` returns a cached instance of a FileSystem and I guess it might be better to leave the cached one rather than removing it from the cache?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org