You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/05/06 15:57:17 UTC
(datafusion) branch gh-readonly-queue/main/pr-21941-574326cc656341687ea1708814fd27ae82004491 created (now 5c097fd7f2)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-21941-574326cc656341687ea1708814fd27ae82004491
in repository https://gitbox.apache.org/repos/asf/datafusion.git
at 5c097fd7f2 chore: Rust checks are required + merge queue (#21941)
This branch includes the following new commits:
new 5c097fd7f2 chore: Rust checks are required + merge queue (#21941)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
(datafusion) 01/01: chore: Rust checks are required + merge queue (#21941)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-21941-574326cc656341687ea1708814fd27ae82004491
in repository https://gitbox.apache.org/repos/asf/datafusion.git
commit 5c097fd7f2300965ca7fbdac498da92a63f0e816
Author: Dmitrii Blaginin <dm...@blaginin.me>
AuthorDate: Wed May 6 16:56:57 2026 +0100
chore: Rust checks are required + merge queue (#21941)
Closes https://github.com/apache/datafusion/issues/6880
Follow up on https://github.com/apache/datafusion/pull/17538 and
https://github.com/apache/datafusion/pull/21239
https://github.com/apache/datafusion/pull/21239 seems to be working fine
- time to make all the rust changes required to merge it.
This brings two cool things:
1. The most important one - the "merge when ready" button now works 🚀
<img width="923" height="285" alt="image"
src="https://github.com/user-attachments/assets/4f11ecb6-e1d9-473f-815f-b57488042dd3"
/>
You can click this button any time, even right after opening a PR. It
will be automatically merged when:
- all required CI checks (which now include rust) are passing
- you get an approval
I think this should help quite a bit. A lot of people get an approval,
push a nit, and then sit waiting for CI to finish. No more waiting!!
2. We protect ourselves from logical conflicts: cases where develop was
passing before, but someone merged something in the meantime and now
your change is broken on develop - and you don't find out until after
you merge. We hit this almost every month.
One downside: before, clicking merge would happen instantly (although
you had **manually** to wait for tests to be green). With this PR, you
won't have to wait, but it will take 16 minutes to merge (plus, 16 more
to put in the merge queue if you just pushed). But github will do the
work itself and ensure tests are passing on the latest `main`.
---
.asf.yaml | 23 +++++++++++++++++++++++
.github/workflows/rust.yml | 7 ++-----
2 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index 47a18d13cb..ee337fad7c 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -60,6 +60,29 @@ github:
- "Spell Check with Typos"
- "Circular Dependency Check"
- "Detect Unused Dependencies"
+ - "linux build test"
+ - "cargo check datafusion-common features"
+ - "cargo check datafusion-substrait features"
+ - "cargo check datafusion-proto features"
+ - "cargo check datafusion features"
+ - "cargo check datafusion-functions features"
+ - "cargo test (amd64)"
+ - "cargo test datafusion-cli (amd64)"
+ - "cargo examples (amd64)"
+ - "cargo test doc (amd64)"
+ - "cargo doc"
+ - "build and run with wasm-pack"
+ - "verify benchmark results (amd64)"
+ - "Run sqllogictest with Postgres runner"
+ - "Run sqllogictest in Substrait round-trip mode"
+ - "cargo test (macos-aarch64)"
+ - "Verify Vendored Code"
+ - "Check cargo fmt"
+ - "clippy"
+ - "check Cargo.toml formatting"
+ - "check configs.md and ***_functions.md is up-to-date"
+ - "check example README is up-to-date"
+ - "Verify MSRV (Min Supported Rust Version)"
# needs to be updated as part of the release process
# .asf.yaml doesn't support wildcard branch protection rules, only exact branch names
# https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#branch-protection
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 3f6462f0f0..f6140ce5b4 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -33,14 +33,11 @@ on:
- ".github/ISSUE_TEMPLATE/**"
- ".github/pull_request_template.md"
pull_request:
- paths-ignore:
- - "docs/**"
- - "**.md"
- - ".github/ISSUE_TEMPLATE/**"
- - ".github/pull_request_template.md"
# manual trigger
# https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
workflow_dispatch:
+ merge_group:
+
permissions:
contents: read
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org