You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Torben Brodt (JIRA)" <ji...@apache.org> on 2011/03/19 10:31:30 UTC
[jira] Created: (THRIFT-1098) Undefined properties in
TBinaryProtocolFactory
Undefined properties in TBinaryProtocolFactory
----------------------------------------------
Key: THRIFT-1098
URL: https://issues.apache.org/jira/browse/THRIFT-1098
Project: Thrift
Issue Type: Bug
Components: PHP - Library
Affects Versions: 0.6
Environment: all php versions
(appropiate for users running a php server)
Reporter: Torben Brodt
Priority: Critical
missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
thats the fix:
Index: src/protocol/TBinaryProtocol.php
===================================================================
--- src/protocol/TBinaryProtocol.php (Revision 1083148)
+++ src/protocol/TBinaryProtocol.php (Arbeitskopie)
@@ -403,7 +403,7 @@
}
public function getProtocol($trans) {
- return new TBinaryProtocol($trans, $this->strictRead, $this->strictWrite);
+ return new TBinaryProtocol($trans, $this->strictRead_, $this->strictWrite_);
}
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1098) Undefined properties in
TBinaryProtocolFactory
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1098.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Torben Brodt
I just committed this patch. Thanks for the contribution, Torben!
> Undefined properties in TBinaryProtocolFactory
> ----------------------------------------------
>
> Key: THRIFT-1098
> URL: https://issues.apache.org/jira/browse/THRIFT-1098
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.6
> Environment: all php versions
> (appropiate for users running a php server)
> Reporter: Torben Brodt
> Assignee: Torben Brodt
> Priority: Critical
> Labels: TBinaryProtocolFactory, php, simpleserver
> Fix For: 0.7
>
> Attachments: patch.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
> PHP Notice: Undefined property: TBinaryProtocolFactory::$strictRead in /usr/share/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
> PHP Notice: Undefined property: TBinaryProtocolFactory::$strictWrite in /usr/share/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1098) Undefined properties in
TBinaryProtocolFactory
Posted by "Torben Brodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torben Brodt updated THRIFT-1098:
---------------------------------
Description:
missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
PHP Notice: Undefined property: TBinaryProtocolFactory::$strictRead in /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
PHP Notice: Undefined property: TBinaryProtocolFactory::$strictWrite in /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
was:
missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
thats the fix:
Index: src/protocol/TBinaryProtocol.php
===================================================================
--- src/protocol/TBinaryProtocol.php (Revision 1083148)
+++ src/protocol/TBinaryProtocol.php (Arbeitskopie)
@@ -403,7 +403,7 @@
}
public function getProtocol($trans) {
- return new TBinaryProtocol($trans, $this->strictRead, $this->strictWrite);
+ return new TBinaryProtocol($trans, $this->strictRead_, $this->strictWrite_);
}
}
added patch as file. removed inline patch
> Undefined properties in TBinaryProtocolFactory
> ----------------------------------------------
>
> Key: THRIFT-1098
> URL: https://issues.apache.org/jira/browse/THRIFT-1098
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.6
> Environment: all php versions
> (appropiate for users running a php server)
> Reporter: Torben Brodt
> Priority: Critical
> Labels: TBinaryProtocolFactory, php, simpleserver
> Attachments: patch.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
> PHP Notice: Undefined property: TBinaryProtocolFactory::$strictRead in /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
> PHP Notice: Undefined property: TBinaryProtocolFactory::$strictWrite in /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1098) Undefined properties in
TBinaryProtocolFactory
Posted by "Torben Brodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torben Brodt updated THRIFT-1098:
---------------------------------
Attachment: patch.diff
this is the patch
> Undefined properties in TBinaryProtocolFactory
> ----------------------------------------------
>
> Key: THRIFT-1098
> URL: https://issues.apache.org/jira/browse/THRIFT-1098
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.6
> Environment: all php versions
> (appropiate for users running a php server)
> Reporter: Torben Brodt
> Priority: Critical
> Labels: TBinaryProtocolFactory, php, simpleserver
> Attachments: patch.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
> thats the fix:
> Index: src/protocol/TBinaryProtocol.php
> ===================================================================
> --- src/protocol/TBinaryProtocol.php (Revision 1083148)
> +++ src/protocol/TBinaryProtocol.php (Arbeitskopie)
> @@ -403,7 +403,7 @@
> }
>
> public function getProtocol($trans) {
> - return new TBinaryProtocol($trans, $this->strictRead, $this->strictWrite);
> + return new TBinaryProtocol($trans, $this->strictRead_, $this->strictWrite_);
> }
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1098) Undefined properties in
TBinaryProtocolFactory
Posted by "Torben Brodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torben Brodt updated THRIFT-1098:
---------------------------------
Description:
missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
PHP Notice: Undefined property: TBinaryProtocolFactory::$strictRead in /usr/share/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
PHP Notice: Undefined property: TBinaryProtocolFactory::$strictWrite in /usr/share/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
was:
missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
PHP Notice: Undefined property: TBinaryProtocolFactory::$strictRead in /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
PHP Notice: Undefined property: TBinaryProtocolFactory::$strictWrite in /usr/share/plista/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
> Undefined properties in TBinaryProtocolFactory
> ----------------------------------------------
>
> Key: THRIFT-1098
> URL: https://issues.apache.org/jira/browse/THRIFT-1098
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.6
> Environment: all php versions
> (appropiate for users running a php server)
> Reporter: Torben Brodt
> Priority: Critical
> Labels: TBinaryProtocolFactory, php, simpleserver
> Attachments: patch.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> missing underscore in variablename. Thrift PHP SimpleServer ist not running without this fix.
> PHP Notice: Undefined property: TBinaryProtocolFactory::$strictRead in /usr/share/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
> PHP Notice: Undefined property: TBinaryProtocolFactory::$strictWrite in /usr/share/library/3rdparty/thrift/protocol/TBinaryProtocol.php on line 406
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira