You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/29 15:11:29 UTC

[GitHub] [nifi] mattyb149 commented on a diff in pull request #6243: NIFI-10192 Cache schema request result for reuse

mattyb149 commented on code in PR #6243:
URL: https://github.com/apache/nifi/pull/6243#discussion_r957459853


##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LookupRecord.java:
##########
@@ -536,6 +536,8 @@ public int getLookupCount() {
     private class RecordPathReplacementStrategy implements ReplacementStrategy {
         private int lookupCount = 0;
 
+        private ArrayList SCHEMA_LOOKUP_RESULT_CACHE = new ArrayList();

Review Comment:
   Although this isn't a CheckStyle error, we usually reserve variable names in all caps to constants. Perhaps change to `schemaLookupResultCache`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org