You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 15:32:25 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2305: More docs
tustvold opened a new pull request, #2305:
URL: https://github.com/apache/arrow-rs/pull/2305
Continues the process of adding more documentation, this adds a section on how to get LLVM to be slightly less conservative and use instructions from this decade :laughing:
I put this as the first thing in the crate docs, as I think it is important, and highlights that we care about performance, but happy to move if people feel differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2305: Add Target Feature Recommendations to Arrow Crate Docs
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2305:
URL: https://github.com/apache/arrow-rs/pull/2305#discussion_r937133988
##########
arrow/src/lib.rs:
##########
@@ -18,6 +18,42 @@
//! A complete, safe, native Rust implementation of [Apache Arrow](https://arrow.apache.org), a cross-language
//! development platform for in-memory data.
//!
+//! # Performance Tips
+//!
+//! Arrow aims to be as fast as possible out of the box, whilst not compromising on safety. However,
+//! it relies heavily on LLVM auto-vectorisation to achieve this. Unfortunately the LLVM defaults,
+//! particularly for x86_64, favour portability over performance, and LLVM will consequently avoid
+//! using more recent instructions that would result in errors on older CPUs.
+//!
+//! To address this it is recommended that you specify the override the LLVM defaults either
Review Comment:
Oops wording error here, will fix 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2305: Add Target Feature Recommendations to Arrow Crate Docs
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2305:
URL: https://github.com/apache/arrow-rs/pull/2305#issuecomment-1204321514
Benchmark runs are scheduled for baseline = f78d2e6572c5b60d00a15084875d90d3e31c9b74 and contender = 2cf4cd8f1c570b91880cdc043624bb7be40a3657. 2cf4cd8f1c570b91880cdc043624bb7be40a3657 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a521e0cd5004441fafd12c54b9187eb8...c3d9c62ce8f141dbac49216375e27994/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/428ac2dcc34f4f39af688ef05af65f1c...0b8ec2f4717f45bb95c357de895b937c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8f810ae157ea4b8eae79e54709578e79...b9a51e8d4cb845c58b110f81c7be9a49/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0de4338c0f7444a59c408e443366b434...bc9ad341f79b4abbaf0b8e7653c5bc65/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2305: Add Target Feature Recommendations to Arrow Crate Docs
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2305:
URL: https://github.com/apache/arrow-rs/pull/2305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org