You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/02/08 09:41:16 UTC
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set align middle for `td`
- Keep same min-height between input and textarea
- Add border-radius 3px;
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
### How should this be tested?
Open the browser and check manually.
### Screenshots (if appropriate)
#### Before: Invalid align
#### Before: Inconsistent min-height
#### After: align
#### After: min-height
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2081/prettify-intp-setting-boxes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-08T09:36:37Z
feat: Set middle align, min height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set align middle for `td`
- Keep same min-height between input and textarea
- Add border-radius 3px;
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
### How should this be tested?
Open the browser and check manually.
### Screenshots (if appropriate)
#### Before: Invalid align
#### Before: Inconsistent min-height
#### After: align
#### After: min-height
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2081/prettify-intp-setting-boxes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-08T09:36:37Z
feat: Set middle align, min height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set align middle for `td`
- Keep same min-height between input and textarea
- Add border-radius 3px;
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
### How should this be tested?
Open the browser and check manually.
### Screenshots (if appropriate)
#### Before: Invalid align
#### Before: Inconsistent min-height
#### After: align
#### After: min-height
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2081/prettify-intp-setting-boxes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-08T09:36:37Z
feat: Set middle align, min height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1991
Thanks for taking care this @1ambda! Tested and looks nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1991
Merge into master and branch-0.7 if there are no comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@AhyoungRyu thanks for review. CI failed but irrelavent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1991
Could or should the front size to be the same in the left and right boxes?
https://cloud.githubusercontent.com/assets/4968473/22731456/15f295ee-ee2e-11e6-915d-e9d7d6236bbd.png
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@1ambda Looks good! Will merge after CI tests are done if there are no comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set align middle for `td`
- Keep same min-height between input and textarea
- Add border-radius 3px;
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
### How should this be tested?
Open the browser and check manually.
### Screenshots (if appropriate)
#### Before: Invalid align
#### Before: Inconsistent min-height
#### After: align
#### After: min-height
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2081/prettify-intp-setting-boxes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-08T09:36:37Z
feat: Set middle align, min height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@1ambda CI is failed only in Selenium test like below
```
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//i[@tooltip='WebSocket Connected']"}
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-docker-88bd8952-3a71-4bd6-9ab2-4b1a5ee75b91', ip: '172.17.0.6', os.name: 'Linux', os.arch: 'amd64', os.version: '4.8.12-040812-generic', java.version: '1.7.0_76'
Driver info: driver.version: unknown
at <anonymous class>.FirefoxDriver.prototype.findElementInternal_(file:///tmp/anonymous5623099368356690573webdriver-profile/extensions/fxdriver@googlecode.com/components/driver-component.js:10659)
at <anonymous class>.fxdriver.Timer.prototype.setTimeout/<.notify(file:///tmp/anonymous5623099368356690573webdriver-profile/extensions/fxdriver@googlecode.com/components/driver-component.js:621)
Tests run: 2, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 75.142 sec <<< FAILURE! - in org.apache.zeppelin.integration.InterpreterIT
```
Seems it's not directly related to this change, but can we retrigger again just to make sure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@AhyoungRyu Passed selenium tests.
- https://travis-ci.org/apache/zeppelin/builds/200883455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@felixcheung Fixed. (`font-size: 12`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set align middle for `td`
- Keep same min-height between input and textarea
- Add border-radius 3px;
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
### How should this be tested?
Open the browser and check manually.
### Screenshots (if appropriate)
#### Before: Invalid align
#### Before: Inconsistent min-height
#### After: align
#### After: min-height
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2081/prettify-intp-setting-boxes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-08T09:36:37Z
feat: Set middle align, min height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set align middle for `td`
- Keep same min-height between input and textarea
- Add border-radius 3px;
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
### How should this be tested?
Open the browser and check manually.
### Screenshots (if appropriate)
#### Before: Invalid align
#### Before: Inconsistent min-height
#### After: align
#### After: min-height
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2081/prettify-intp-setting-boxes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-08T09:36:37Z
feat: Set middle align, min height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1991: [ZEPPELIN-2081] Prettify input, textarea in interprete...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1991
Some CI tests are failed but it's not related to this change. I'm merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set align middle for `td`
- Keep same min-height between input and textarea
- Add border-radius 3px;
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
### How should this be tested?
Open the browser and check manually.
### Screenshots (if appropriate)
#### Before: Invalid align
#### Before: Inconsistent min-height
#### After: align
#### After: min-height
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2081/prettify-intp-setting-boxes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-08T09:36:37Z
feat: Set middle align, min height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---