[GitHub] [kafka] junrao commented on a diff in pull request #14305: KAFKA-14274: [1/7] basic refactoring

["junrao (via GitHub)" <gi...@apache.org>]

junrao commented on code in PR #14305:
URL: https://github.com/apache/kafka/pull/14305#discussion_r1316250831


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -363,6 +365,20 @@ private CompletableFuture<Map<TopicPartition, OffsetAndMetadata>> chainFuture(fi
                 }
             });
         }
+
+        @Override
+        public String toString() {
+            return "OffsetFetchRequestState{" +
+                    "requestedPartitions=" + requestedPartitions +
+                    ", requestedGeneration=" + requestedGeneration +
+                    ", future=" + future +
+                    ", exponentialBackoff=" + exponentialBackoff +
+                    ", lastSentMs=" + lastSentMs +
+                    ", lastReceivedMs=" + lastReceivedMs +
+                    ", numAttempts=" + numAttempts +
+                    ", backoffMs=" + backoffMs +

Review Comment:
   Instead of duplicating the code in RequestState, could we pull out the common part as a util and reuse?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org