You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/09/28 07:04:06 UTC
Review Request 68872: Specified `--type=container` for `docker
inspect` command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-9231
https://issues.apache.org/jira/browse/MESOS-9231
Repository: mesos
Description
-------
Without `--type` option, `docker inspect` is generic and will match
against any object types. However in our case, we only care about
Docker container rather than any other object types, so we need to
add `--type=container` so that `docker inspect` will only match Docker
container.
Diffs
-----
src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113
Diff: https://reviews.apache.org/r/68872/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68872: Specified `--type=container` for `docker
inspect` command.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/#review209089
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68872']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2404/mesos-review-68872
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2404/mesos-review-68872/logs/mesos-tests.log):
```
I0928 08:04:23.413336 732 executor.cpp:796] Shutting down
I0928 08:04:23.413336 732 executor.cpp:909] Sending SIGTERM to process tree at pid 8542e4b11f-c1e7-4afc-913c-852c90301a08-0000 at executor(1)@192.10.1.5:57947
I0928 08:04:23.413336 7596 master.cpp:11030] Removing task 5c891bb8-cd02-460e-9279-293c07abc560 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework e2e4b11f-c1e7-4afc-913c-852c90301a08-0000 on agent e2e4b11f-c1e7-4afc-913c-852c90301a08-S0 at slave(463)@192.10.1.5:56137 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0928 08:04:23.414351 936 slave.cpp:909] Agent terminating
W0928 08:04:23.414351 936 slave.cpp:3917] Ignoring shutdown framework e2e4b11f-c1e7-4afc-913c-852c90301a08-0000 because it is terminating
I0928 08:04:23.417388 5596 master.cpp:1251] Agent e2e4b11f-c1e7-4afc-913c-852c90301a08-S0 at slave(463)@192.10.1.5:56137 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I0928 08:04:23.417388 5596 master.cpp:3267] Disconnecting agent e2e4b11f-c1e7-4afc-913c-852c90301a08-S0 at slave(463)@192.10.1.5:56137 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0928 08:04:23.417388 5596 master.cpp:3286] Deactivating agent e2e4b11f-c1e7-4afc-913c-852c90301a08-S0 at slave(463)@192.10.1.5:56137 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0928 08:04:23.418347 6864 hierarchical.cpp:359] Removed framework e2e4b11f-c1e7-4afc-913c-852c90301a08-0000
I0928 08:04:23.418347 6864 hierarchical.cpp:803] Agent e2e4b11f-c1e7-4afc-913c-852c90301a08-S0 deactivated
I0928 08:04:23.419349 4524 containerizer.cpp:2455] Destroying container 74538560-5124-4103-9ed2-90225aa8c1ea in RUNNING state
I0928 08:04:23.419349 4524 containerizer.cpp:3118] Transitioning the state of container 74538560-5124-4103-9ed2-90225aa8c1ea from RUNNING to DESTROYING
I0928 08:04:23.420351 4524 launcher.cpp:166] Asked to destroy container 74538560-5124-4103-9ed2-90225aa8c1ea
I0928 08:04:23.494354 6864 containerizer.cpp:2957] Container 74538560-5124-4103-9ed2-90225aa8c1ea has exited
I0928 08:04:23.524333 936 master.cpp[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (693 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (715 ms total)
[----------] Global test environment tear-down
[==========] 1052 tests from 103 test cases ran. (490108 ms total)
[ PASSED ] 1051 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
:1093] Master terminating
I0928 08:04:23.526329 8676 hierarchical.cpp:645] Removed agent e2e4b11f-c1e7-4afc-913c-852c90301a08-S0
I0928 08:04:23.791326 7468 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Sept. 28, 2018, 7:04 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68872/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2018, 7:04 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9231
> https://issues.apache.org/jira/browse/MESOS-9231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without `--type` option, `docker inspect` is generic and will match
> against any object types. However in our case, we only care about
> Docker container rather than any other object types, so we need to
> add `--type=container` so that `docker inspect` will only match Docker
> container.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113
>
>
> Diff: https://reviews.apache.org/r/68872/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68872: Specified `--type=container` for `docker
inspect` command.
Posted by Qian Zhang <zh...@gmail.com>.
> On Sept. 29, 2018, 9:06 a.m., Gilbert Song wrote:
> > Could we verify the minimum supported docker version?
The `--type` option was added into `docker inspect` in Docker 1.8.0, see https://github.com/moby/moby/releases/tag/v1.8.0 for more details.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/#review209113
-----------------------------------------------------------
On Sept. 28, 2018, 3:04 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68872/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2018, 3:04 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9231
> https://issues.apache.org/jira/browse/MESOS-9231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without `--type` option, `docker inspect` is generic and will match
> against any object types. However in our case, we only care about
> Docker container rather than any other object types, so we need to
> add `--type=container` so that `docker inspect` will only match Docker
> container.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113
>
>
> Diff: https://reviews.apache.org/r/68872/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68872: Specified `--type=container` for `docker
inspect` command.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/#review209113
-----------------------------------------------------------
Ship it!
Could we verify the minimum supported docker version?
- Gilbert Song
On Sept. 28, 2018, 12:04 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68872/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2018, 12:04 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9231
> https://issues.apache.org/jira/browse/MESOS-9231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without `--type` option, `docker inspect` is generic and will match
> against any object types. However in our case, we only care about
> Docker container rather than any other object types, so we need to
> add `--type=container` so that `docker inspect` will only match Docker
> container.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113
>
>
> Diff: https://reviews.apache.org/r/68872/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68872: Specified `--type=container` for `docker
inspect` command.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/#review209121
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Sept. 28, 2018, 8:22 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68872/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2018, 8:22 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9231
> https://issues.apache.org/jira/browse/MESOS-9231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without `--type` option, `docker inspect` is generic and will match
> against any object types. However in our case, we only care about
> Docker container rather than any other object types, so we need to
> add `--type=container` so that `docker inspect` will only match Docker
> container.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113
>
>
> Diff: https://reviews.apache.org/r/68872/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68872: Specified `--type=container` for `docker
inspect` command.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/#review209115
-----------------------------------------------------------
PASS: Mesos patch 68872 was successfully built and tested.
Reviews applied: `['68882', '68872']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2406/mesos-review-68872
- Mesos Reviewbot Windows
On Sept. 29, 2018, 3:22 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68872/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2018, 3:22 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9231
> https://issues.apache.org/jira/browse/MESOS-9231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without `--type` option, `docker inspect` is generic and will match
> against any object types. However in our case, we only care about
> Docker container rather than any other object types, so we need to
> add `--type=container` so that `docker inspect` will only match Docker
> container.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113
>
>
> Diff: https://reviews.apache.org/r/68872/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68872: Specified `--type=container` for `docker
inspect` command.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/
-----------------------------------------------------------
(Updated Sept. 29, 2018, 11:22 a.m.)
Review request for mesos and Gilbert Song.
Bugs: MESOS-9231
https://issues.apache.org/jira/browse/MESOS-9231
Repository: mesos
Description
-------
Without `--type` option, `docker inspect` is generic and will match
against any object types. However in our case, we only care about
Docker container rather than any other object types, so we need to
add `--type=container` so that `docker inspect` will only match Docker
container.
Diffs
-----
src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113
Diff: https://reviews.apache.org/r/68872/diff/1/
Testing
-------
Thanks,
Qian Zhang