You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/15 13:57:48 UTC

[GitHub] [camel-k] squakez edited a comment on pull request #2216: feat(monitoring): Migrate to PodMonitor for Integration monitoring

squakez edited a comment on pull request #2216:
URL: https://github.com/apache/camel-k/pull/2216#issuecomment-820437579


   We have too many places where we just don't set the `SourceType` right now in the code. For the OpenAPI, for example it's [here](https://github.com/apache/camel-k/blob/master/pkg/trait/openapi.go#L127-L134) but I've found a few more. I've provided a defensive solution for the time being in order to avoid any possible NPE but I think we need a more devised solution.
   
   I think we should understand if we want always to set the `SourceType` and hence enforce it in all parts of the code here in Camel K.
   
   I will better follow up with a separate issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org