[GitHub] williaster commented on a change in pull request #5213: [fix] new dashboard state

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5213: [fix] new dashboard state
URL: https://github.com/apache/incubator-superset/pull/5213#discussion_r196211988
 
 

 ##########
 File path: superset/assets/src/dashboard/reducers/getInitialState.js
 ##########
 @@ -18,11 +18,13 @@ import {
 } from '../util/componentTypes';
 
 export default function(bootstrapData) {
+  // ignore editMode flag from server side.
 
 Review comment:
   I don't think we should ignore this here, I think it's better for it simply _not_ to be set on explore view side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org