You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/26 01:58:02 UTC

[GitHub] [maven] michael-o commented on a change in pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

michael-o commented on a change in pull request #641:
URL: https://github.com/apache/maven/pull/641#discussion_r775186215



##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
##########
@@ -86,6 +86,39 @@ public String getVersion()
         }
     }
 
+    @Override
+    public Artifact setVersion( String version )
+    {
+         String current = getVersion();
+         if ( current.equals( version ) || ( version == null && current.length() <= 0 ) )

Review comment:
       While this is true, I wanted to retain the same code block as in `AbstractArtifact` for consistency reasons  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org