You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/11 16:07:21 UTC
[GitHub] [tvm] NicolaLancellotti opened a new pull request, #13762: Remove tutorials CMSIS dependencies when not needed
NicolaLancellotti opened a new pull request, #13762:
URL: https://github.com/apache/tvm/pull/13762
Pr #13656 added support for CMSIS NN from a new GitHub location.
The project at the new location uses a new header `arm_acle.h` which is not always present.
This pr removes the CMSIS dependency for the tutorials in `gallery/how_to/work_with_microtvm` when the tutorials are run with Zephyr.
We need this pr, otherwise, when the docker image will be updated there will be errors, due to the missing header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NicolaLancellotti commented on pull request #13762: Remove tutorials CMSIS dependency when not needed
Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on PR #13762:
URL: https://github.com/apache/tvm/pull/13762#issuecomment-1380236687
> This looks good, but do these tutorials still need to include instructions to install CMSIS? I'd love to remove this from `micro_aot.py`, `micro_autotune.py`, and `micro_tflite.py` if we can.
>
> ```python
> ######################################################################
> #
> # .. include:: ../../../../gallery/how_to/work_with_microtvm/install_dependencies.rst
> #
> ```
Done. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13762: Remove tutorials CMSIS dependencies when not needed
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13762:
URL: https://github.com/apache/tvm/pull/13762#issuecomment-1379042534
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NicolaLancellotti commented on a diff in pull request #13762: Remove tutorials CMSIS dependency when not needed
Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on code in PR #13762:
URL: https://github.com/apache/tvm/pull/13762#discussion_r1068501892
##########
gallery/how_to/work_with_microtvm/install_cmsis.rst:
##########
@@ -1,35 +0,0 @@
-.. Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I re-added the file and edited it adding the commands to download CMSIS NN from the new GitHub location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NicolaLancellotti commented on pull request #13762: Remove tutorials CMSIS dependencies when not needed
Posted by GitBox <gi...@apache.org>.
NicolaLancellotti commented on PR #13762:
URL: https://github.com/apache/tvm/pull/13762#issuecomment-1379044445
@ashutosh-arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #13762: Remove tutorials CMSIS dependency when not needed
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #13762:
URL: https://github.com/apache/tvm/pull/13762#discussion_r1068381448
##########
gallery/how_to/work_with_microtvm/install_cmsis.rst:
##########
@@ -1,35 +0,0 @@
-.. Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Please don't remove this file as we will need it in future tutorials
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] guberti merged pull request #13762: Remove tutorials CMSIS dependency when not needed
Posted by GitBox <gi...@apache.org>.
guberti merged PR #13762:
URL: https://github.com/apache/tvm/pull/13762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org