You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/29 15:18:55 UTC

[GitHub] [flink] JackWangCS opened a new pull request #17609: [FLINK-24663][Python] Quote bash argument for PythonEnvironmentManagerUtils

JackWangCS opened a new pull request #17609:
URL: https://github.com/apache/flink/pull/17609


   ## What is the purpose of the change
   PyFlink failed to get the site packege path and thus failed install 3rd party dependencies because of SyntaxError in shell command. This PR quotes long bash argument for PythonEnvironmentManagerUtils to solve this issue.
   
   
   ## Brief change log
   Quote long python bash argument for PythonEnvironmentManagerUtils
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - *Add new test `testBashQuoteString()` in PythonEnvironmentManagerUtilsTest to test the string quoting. *
   The functionality of `PythonEnvironmentManagerUtils`  already be covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17609: [FLINK-24663][Python] Quote bash argument for PythonEnvironmentManagerUtils

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17609:
URL: https://github.com/apache/flink/pull/17609#issuecomment-954831151


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6f0fdb55ef06c57617fec52c42a0c650d938e371 (Fri Oct 29 15:23:15 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24663).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17609: [FLINK-24663][Python] Quote bash argument for PythonEnvironmentManagerUtils

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17609:
URL: https://github.com/apache/flink/pull/17609#issuecomment-954829138


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6f0fdb55ef06c57617fec52c42a0c650d938e371",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6f0fdb55ef06c57617fec52c42a0c650d938e371",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6f0fdb55ef06c57617fec52c42a0c650d938e371 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JackWangCS closed pull request #17609: [FLINK-24663][Python] Quote bash argument for PythonEnvironmentManagerUtils

Posted by GitBox <gi...@apache.org>.
JackWangCS closed pull request #17609:
URL: https://github.com/apache/flink/pull/17609


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17609: [FLINK-24663][Python] Quote bash argument for PythonEnvironmentManagerUtils

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17609:
URL: https://github.com/apache/flink/pull/17609#issuecomment-954829138


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6f0fdb55ef06c57617fec52c42a0c650d938e371",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25650",
       "triggerID" : "6f0fdb55ef06c57617fec52c42a0c650d938e371",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6f0fdb55ef06c57617fec52c42a0c650d938e371 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25650) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17609: [FLINK-24663][Python] Quote bash argument for PythonEnvironmentManagerUtils

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17609:
URL: https://github.com/apache/flink/pull/17609#issuecomment-954829138


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6f0fdb55ef06c57617fec52c42a0c650d938e371",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25650",
       "triggerID" : "6f0fdb55ef06c57617fec52c42a0c650d938e371",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6f0fdb55ef06c57617fec52c42a0c650d938e371 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25650) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org