You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/31 10:06:52 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
MaxGekk opened a new pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057
### What changes were proposed in this pull request?
In the PR, I propose to throw `AnalysisException` when a removed SQL config is set to non-default value. The following SQL configs removed by #26559 are marked as removed:
1. `spark.sql.fromJsonForceNullableSchema`
2. `spark.sql.legacy.compareDateTimestampInTimestamp`
3. `spark.sql.legacy.allowCreatingManagedTableUsingNonemptyLocation`
### Why are the changes needed?
To improve user experience with Spark SQL by notifying of removed SQL configs used by users.
### Does this PR introduce any user-facing change?
Yes, before the `set` command was silently ignored:
```sql
spark-sql> set spark.sql.fromJsonForceNullableSchema=false;
spark.sql.fromJsonForceNullableSchema false
```
after the exception should be raised:
```sql
spark-sql> set spark.sql.fromJsonForceNullableSchema=false;
Error in query: The SQL config 'spark.sql.fromJsonForceNullableSchema' was removed in the version 3.0.0.;
```
### How was this patch tested?
Added new tests into `SQLConfSuite` for both cases when removed SQL configs are set to default and non-default values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570325922
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116044/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570228840
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570218906
cc @vanzin @cloud-fan @gatorsmile who I talked about this with
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569933882
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569933882
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569933577
**[Test build #115984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115984/testReport)** for PR 27057 at commit [`73f887c`](https://github.com/apache/spark/commit/73f887cdfb3ae55e14d23200346099af481d9fab).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570325922
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116044/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569933887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115984/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570241427
**[Test build #116044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116044/testReport)** for PR 27057 at commit [`e9e63ae`](https://github.com/apache/spark/commit/e9e63ae1adcb43ee404f6ebb1be9c86fac9c67e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569902778
**[Test build #115984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115984/testReport)** for PR 27057 at commit [`73f887c`](https://github.com/apache/spark/commit/73f887cdfb3ae55e14d23200346099af481d9fab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569903060
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#discussion_r362496655
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -320,4 +320,16 @@ class SQLConfSuite extends QueryTest with SharedSparkSession {
assert(e2.getMessage.contains("spark.sql.shuffle.partitions"))
}
+ test("set removed configs to non-default values") {
+ Seq(
+ "spark.sql.fromJsonForceNullableSchema" -> false,
Review comment:
shall we only test one config? Otherwise we may need to update this test again and again when we remove more configs in the future.
In `cannot set/unset static SQL conf` we only test one config too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570228840
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569903060
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570431336
Merged to master.
@MaxGekk are you also interested in grouping deprecated configurations too? Hope we can remove out legacy configurations out a bit more aggressively by leveraging those mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569902778
**[Test build #115984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115984/testReport)** for PR 27057 at commit [`73f887c`](https://github.com/apache/spark/commit/73f887cdfb3ae55e14d23200346099af481d9fab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570172865
**[Test build #116030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116030/testReport)** for PR 27057 at commit [`9b7bd7a`](https://github.com/apache/spark/commit/9b7bd7a9e0981b2f442df69c70e94c158a6f72ff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570239084
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570228848
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116030/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570472555
> are you also interested in grouping deprecated configurations too?
yes, I am.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570173260
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20822/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570172865
**[Test build #116030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116030/testReport)** for PR 27057 at commit [`9b7bd7a`](https://github.com/apache/spark/commit/9b7bd7a9e0981b2f442df69c70e94c158a6f72ff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570241427
**[Test build #116044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116044/testReport)** for PR 27057 at commit [`e9e63ae`](https://github.com/apache/spark/commit/e9e63ae1adcb43ee404f6ebb1be9c86fac9c67e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570228167
LGTM, nice feature!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570173260
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20822/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570325908
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570228848
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116030/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570239094
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20835/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570173257
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570325071
**[Test build #116044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116044/testReport)** for PR 27057 at commit [`e9e63ae`](https://github.com/apache/spark/commit/e9e63ae1adcb43ee404f6ebb1be9c86fac9c67e8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570239094
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20835/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569933887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115984/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#discussion_r362507845
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -320,4 +320,16 @@ class SQLConfSuite extends QueryTest with SharedSparkSession {
assert(e2.getMessage.contains("spark.sql.shuffle.partitions"))
}
+ test("set removed configs to non-default values") {
+ Seq(
+ "spark.sql.fromJsonForceNullableSchema" -> false,
Review comment:
I agree. I will test only `spark.sql.fromJsonForceNullableSchema`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570325908
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570239084
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#discussion_r362668497
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -170,6 +170,36 @@ object SQLConf {
}
}
+ /**
+ * Holds information about keys that have been removed.
+ *
+ * @param key The removed config key.
+ * @param version Version of Spark where key was removed.
+ * @param defaultValue The default config value. It can be used to notice
+ * users that they set non-default value to an already removed config.
+ * @param comment Additional info regarding to the removed config.
+ */
+ case class RemovedConfig(key: String, version: String, defaultValue: String, comment: String)
+
+ /**
+ * The map contains info about removed SQL configs. Keys are SQL config names,
+ * map values contain extra information like the version in which the config was removed,
+ * config's default value and a comment.
+ */
+ val removedSQLConfigs: Map[String, RemovedConfig] = {
+ val configs = Seq(
+ RemovedConfig("spark.sql.fromJsonForceNullableSchema", "3.0.0", "true",
+ "It was removed to prevent errors like SPARK-23173 for non-default value."),
+ RemovedConfig(
+ "spark.sql.legacy.allowCreatingManagedTableUsingNonemptyLocation", "3.0.0", "false",
+ "It was removed to prevent loosing of users data for non-default value."),
+ RemovedConfig("spark.sql.legacy.compareDateTimestampInTimestamp", "3.0.0", "true",
+ "It was removed to prevent errors like SPARK-23549 for non-default value.")
+ )
Review comment:
Looks a nice feature. Just a question; any policy about when these entries will be removed in this list? We need to keep them forever, or we can remove them sometime?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569903065
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20776/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#discussion_r362353286
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -170,6 +170,16 @@ object SQLConf {
}
}
+ /**
+ * The map contains info about removed SQL configs. Keys are SQL config names,
+ * map values are tuples of default config value and the version in which
+ * the SQL config was removed.
+ */
+ val removedSQLConfigs = Map[String, (String, String)](
Review comment:
Oh, yeah. I was thinking about having this mechanism in SQL configurations too but couldn't find some time to fix.
There is an example to follow in `SparkConf`, for example, see `deprecatedConfigs`.
Can you match how it looks like? Then it should be good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#discussion_r362686673
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -170,6 +170,36 @@ object SQLConf {
}
}
+ /**
+ * Holds information about keys that have been removed.
+ *
+ * @param key The removed config key.
+ * @param version Version of Spark where key was removed.
+ * @param defaultValue The default config value. It can be used to notice
+ * users that they set non-default value to an already removed config.
+ * @param comment Additional info regarding to the removed config.
+ */
+ case class RemovedConfig(key: String, version: String, defaultValue: String, comment: String)
+
+ /**
+ * The map contains info about removed SQL configs. Keys are SQL config names,
+ * map values contain extra information like the version in which the config was removed,
+ * config's default value and a comment.
+ */
+ val removedSQLConfigs: Map[String, RemovedConfig] = {
+ val configs = Seq(
+ RemovedConfig("spark.sql.fromJsonForceNullableSchema", "3.0.0", "true",
+ "It was removed to prevent errors like SPARK-23173 for non-default value."),
+ RemovedConfig(
+ "spark.sql.legacy.allowCreatingManagedTableUsingNonemptyLocation", "3.0.0", "false",
+ "It was removed to prevent loosing of users data for non-default value."),
+ RemovedConfig("spark.sql.legacy.compareDateTimestampInTimestamp", "3.0.0", "true",
+ "It was removed to prevent errors like SPARK-23549 for non-default value.")
+ )
Review comment:
I think we can remove those after few minor releases or when we bump up the major release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#discussion_r362353338
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -170,6 +170,16 @@ object SQLConf {
}
}
+ /**
+ * The map contains info about removed SQL configs. Keys are SQL config names,
+ * map values are tuples of default config value and the version in which
+ * the SQL config was removed.
+ */
+ val removedSQLConfigs = Map[String, (String, String)](
Review comment:
Just to add more info, `deprecatedConfigs` works like `removedSLQConfigs` (because they are deprecated first and removed out).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570173257
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570623469
Here is the PR https://github.com/apache/spark/pull/27092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-570228296
**[Test build #116030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116030/testReport)** for PR 27057 at commit [`9b7bd7a`](https://github.com/apache/spark/commit/9b7bd7a9e0981b2f442df69c70e94c158a6f72ff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27057:
[SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for
removed SQL configs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27057: [SPARK-29930][SQL][FOLLOW-UP] Allow only default value to be set for removed SQL configs
URL: https://github.com/apache/spark/pull/27057#issuecomment-569903065
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20776/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org