You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/22 17:53:11 UTC
[GitHub] [kafka] brbrown25 opened a new pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
brbrown25 opened a new pull request #9057:
URL: https://github.com/apache/kafka/pull/9057
… of message key or value.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] brbrown25 edited a comment on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
brbrown25 edited a comment on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-717322569
- [x] update with latest master
- [ ] implement nested field support
- [ ] implement salt support
- [ ] update rat configuration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] brbrown25 commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
brbrown25 commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-717322569
- [ ] update with latest master
- [ ] implement nested field support
- [ ] implement salt support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-694952594
@brbrown25 I took a quick look at the KIP and replied to the thread on the mailing list.
We do our best to review KIPs but sometimes it can take a little while. You can bump your thread (I recommended replying to the same thread instead of creating a new one in order to keep the history) if it's been a few weeks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] brbrown25 edited a comment on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
brbrown25 edited a comment on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-717322569
- [x] update with latest master
- [ ] implement nested field support
- [ ] implement salt support
- [x] update rat configuration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] brbrown25 commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
brbrown25 commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-694920689
@mimaison I've posted on the mailing list but not gotten any feedback. Is there anything you'd recommend, here is my most recent posting http://mail-archives.apache.org/mod_mbox/kafka-dev/202009.mbox/browser. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] brbrown25 commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
brbrown25 commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-682058178
@mimaison Thank You, I'll review and submit a KIP this afternoon!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] brbrown25 edited a comment on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
brbrown25 edited a comment on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-717322569
- [x] update with latest master
- [ ] implement nested field support
- [ ] implement salt support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] brbrown25 commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
brbrown25 commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-704492883
@mimaison I've updated the kip and put out a vote request but not seeing any action. I've gone ahead and updated this pr to be updated with latest trunk as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-682013531
Thanks for the contribution.
As this is adding new public classes, this change requires a KIP: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org