You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/07 04:15:24 UTC
Review Request: Fixed os::cpus and made os::memory work for OSX.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9793/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See description.
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/os.hpp da14a8fb95b69684c899e04ca79a1ad8eb11b2b8
Diff: https://reviews.apache.org/r/9793/diff/
Testing
-------
Tested manually, I will be splitting apart the monolithic stout tests in another review chain.
Thanks,
Ben Mahler
Re: Review Request: Fixed os::cpus and made os::memory work for OSX.
Posted by Ben Mahler <be...@gmail.com>.
> On March 7, 2013, 6:08 p.m., Vinod Kone wrote:
> > third_party/libprocess/third_party/stout/include/stout/os.hpp, line 870
> > <https://reviews.apache.org/r/9793/diff/1/?file=267807#file267807line870>
> >
> > <= 0 ?
The contract of sysctl is such that on error it returns -1 and sets errno, so if it returns 0, errno will not be set (and hence we'll provide a non-deterministic error message!)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9793/#review17553
-----------------------------------------------------------
On March 7, 2013, 3:15 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9793/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See description.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/os.hpp da14a8fb95b69684c899e04ca79a1ad8eb11b2b8
>
> Diff: https://reviews.apache.org/r/9793/diff/
>
>
> Testing
> -------
>
> Tested manually, I will be splitting apart the monolithic stout tests in another review chain.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed os::cpus and made os::memory work for OSX.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9793/#review17553
-----------------------------------------------------------
Ship it!
third_party/libprocess/third_party/stout/include/stout/os.hpp
<https://reviews.apache.org/r/9793/#comment37209>
<= 0 ?
third_party/libprocess/third_party/stout/include/stout/os.hpp
<https://reviews.apache.org/r/9793/#comment37210>
im surprised this takes int64_t instead of uint64_t!
- Vinod Kone
On March 7, 2013, 3:15 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9793/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See description.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/os.hpp da14a8fb95b69684c899e04ca79a1ad8eb11b2b8
>
> Diff: https://reviews.apache.org/r/9793/diff/
>
>
> Testing
> -------
>
> Tested manually, I will be splitting apart the monolithic stout tests in another review chain.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed os::cpus and made os::memory work for OSX.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9793/
-----------------------------------------------------------
(Updated March 12, 2013, 9:35 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk, no need for review.
Description
-------
See description.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/os.hpp da14a8fb95b69684c899e04ca79a1ad8eb11b2b8
Diff: https://reviews.apache.org/r/9793/diff/
Testing
-------
Tested manually, I will be splitting apart the monolithic stout tests in another review chain.
Thanks,
Ben Mahler
Re: Review Request: Fixed os::cpus and made os::memory work for OSX.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9793/
-----------------------------------------------------------
(Updated March 8, 2013, 2:24 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Reviews, rebased off trunk.
Description
-------
See description.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/os.hpp da14a8fb95b69684c899e04ca79a1ad8eb11b2b8
Diff: https://reviews.apache.org/r/9793/diff/
Testing
-------
Tested manually, I will be splitting apart the monolithic stout tests in another review chain.
Thanks,
Ben Mahler
Re: Review Request: Fixed os::cpus and made os::memory work for OSX.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9793/#review17520
-----------------------------------------------------------
Ship it!
third_party/libprocess/third_party/stout/include/stout/os.hpp
<https://reviews.apache.org/r/9793/#comment37179>
s/len/length?
third_party/libprocess/third_party/stout/include/stout/os.hpp
<https://reviews.apache.org/r/9793/#comment37180>
To make 2 more readable I sometimes will pull out a const size_t NAME_SIZE above and use that.
- Benjamin Hindman
On March 7, 2013, 3:15 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9793/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See description.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/os.hpp da14a8fb95b69684c899e04ca79a1ad8eb11b2b8
>
> Diff: https://reviews.apache.org/r/9793/diff/
>
>
> Testing
> -------
>
> Tested manually, I will be splitting apart the monolithic stout tests in another review chain.
>
>
> Thanks,
>
> Ben Mahler
>
>