You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/25 07:26:39 UTC
[GitHub] [ignite] zstan opened a new pull request #9909: IGNITE-16742 Extend calcite module documentation
zstan opened a new pull request #9909:
URL: https://github.com/apache/ignite/pull/9909
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan closed pull request #9909: IGNITE-16742 Extend calcite module documentation
Posted by GitBox <gi...@apache.org>.
zstan closed pull request #9909:
URL: https://github.com/apache/ignite/pull/9909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on a change in pull request #9909: IGNITE-16742 Extend calcite module documentation
Posted by GitBox <gi...@apache.org>.
zstan commented on a change in pull request #9909:
URL: https://github.com/apache/ignite/pull/9909#discussion_r835121933
##########
File path: modules/calcite/README.txt
##########
@@ -4,7 +4,36 @@ Apache Ignite Calcite Module
Apache Ignite Calcite module provides experimental Apache Calcite based query engine.
To enable Calcite based engine explicit `CalciteQueryEngineConfiguration` instance should be added to
-`SqlConfiguration.QueryEnginesConfiguration` property (see `SqlConfiguration.setQueryEnginesConfiguration()`).
+`SqlConfiguration.QueryEnginesConfiguration` property (see `SqlConfiguration.setQueryEnginesConfiguration()`) or ./config/queries-default.xml.
+Config example:
+
+<bean id="queries.cfg" class="org.apache.ignite.configuration.IgniteConfiguration">
+ <property name="clientConnectorConfiguration">
+ <bean class="org.apache.ignite.configuration.ClientConnectorConfiguration">
+ <property name="host" value="127.0.0.1"/>
+ <property name="port" value="10800"/>
+ <property name="portRange" value="10"/>
+ </bean>
+ </property>
Review comment:
explicit always preferable and more readable that implicit i just want to show dependency between port in config and jdbc url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9909: IGNITE-16742 Extend calcite module documentation
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #9909:
URL: https://github.com/apache/ignite/pull/9909#discussion_r835027619
##########
File path: modules/calcite/README.txt
##########
@@ -13,6 +42,9 @@ When starting a standalone node, move 'optional/ignite-calcite' folder to 'libs'
Note: At now some logic from ignite-indexing module is reused, this means ignite-indexing module also
has to be present at classpath.
+Connection url via jdbc with calcite engine: jdbc:ignite:thin://127.0.0.1:10800?queryEngine=calcite
Review comment:
Let's add something like `If more than one engine configured ... `
Also let's add about other ways to send query to specific engine (ODBC, hints)
JDBC - should be in upper case (perhaps "Calcite", "H2" - start with upper case too).
##########
File path: examples/config/queries-default.xml
##########
@@ -0,0 +1,79 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<beans xmlns="http://www.springframework.org/schema/beans"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xmlns:util="http://www.springframework.org/schema/util"
+ xsi:schemaLocation="
+ http://www.springframework.org/schema/beans
+ http://www.springframework.org/schema/beans/spring-beans.xsd
+ http://www.springframework.org/schema/util
+ http://www.springframework.org/schema/util/spring-util.xsd">
+
+ <bean id="queries.cfg" class="org.apache.ignite.configuration.IgniteConfiguration">
Review comment:
Rename file to `example-sql.xml`?
Inherit configuration from `example-default.xml` and add only `sqlConfiguration`?
##########
File path: modules/calcite/README.txt
##########
@@ -4,7 +4,36 @@ Apache Ignite Calcite Module
Apache Ignite Calcite module provides experimental Apache Calcite based query engine.
To enable Calcite based engine explicit `CalciteQueryEngineConfiguration` instance should be added to
-`SqlConfiguration.QueryEnginesConfiguration` property (see `SqlConfiguration.setQueryEnginesConfiguration()`).
+`SqlConfiguration.QueryEnginesConfiguration` property (see `SqlConfiguration.setQueryEnginesConfiguration()`) or ./config/queries-default.xml.
+Config example:
+
+<bean id="queries.cfg" class="org.apache.ignite.configuration.IgniteConfiguration">
+ <property name="clientConnectorConfiguration">
+ <bean class="org.apache.ignite.configuration.ClientConnectorConfiguration">
+ <property name="host" value="127.0.0.1"/>
+ <property name="port" value="10800"/>
+ <property name="portRange" value="10"/>
+ </bean>
+ </property>
Review comment:
This part looks redundant for SQL configuration documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org