You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/11 02:59:09 UTC
[GitHub] [spark] beliefer opened a new pull request #31548: [SPARK-34127][SQL] Support table valued command
beliefer opened a new pull request #31548:
URL: https://github.com/apache/spark/pull/31548
### What changes were proposed in this pull request?
Some command used to display some metadata, such as: SHOW TABLES, SHOW TBLPROPERTIES and so no.
If the output rows much than screen height, the output very unfriendly to developers.
So we should have a way to filter the output like the behavior of SELECT ... FROM ... WHERE.
We could reference the implement of table valued function.
### Why are the changes needed?
This PR provides a better way to display DDL when output rows much than screen height.
### Does this PR introduce _any_ user-facing change?
'No'. Just a new syntax.
### How was this patch tested?
Jenkins test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-822370918
**[Test build #137585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137585/testReport)** for PR 31548 at commit [`add16cb`](https://github.com/apache/spark/commit/add16cbfd6181dfb6829fc905a10e82fc4bbc070).
* This patch **fails Spark unit tests**.
* This patch **does not merge cleanly**.
* This patch adds the following public classes _(experimental)_:
* `trait FunctionRegistryBase[T] `
* `trait SimpleFunctionRegistryBase[T] extends FunctionRegistryBase[T] with Logging `
* `trait EmptyFunctionRegistryBase[T] extends FunctionRegistryBase[T] `
* `trait FunctionRegistry extends FunctionRegistryBase[Expression] `
* `trait TableFunctionRegistry extends FunctionRegistryBase[LogicalPlan] `
* `case class ResolveTableValuedFunctions(catalog: SessionCatalog) extends Rule[LogicalPlan] `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31548:
URL: https://github.com/apache/spark/pull/31548#discussion_r578182613
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -136,6 +136,29 @@ case class UnresolvedTableValuedFunction(
override lazy val resolved = false
}
+/**
+ * A table-valued command, e.g.
+ * {{{
+ * select tableName from command("show tables");
Review comment:
Yes. This implementation can make these command easy to use:
1. Save result to table.
2. Query the specified column.
3. Filter / Group by / Order by the specified column.
This is the syntax of Teradata:
```sql
SELECT tbl.DatabaseName,
tbl.TableName,
SUM(spc.CurrentPerm)/1024.00 as TableSize
FROM DBC.TablesV tbl
JOIN DBC.TableSize spc
ON tbl.DatabaseName = spc.DatabaseName
AND tbl.TableName = spc.TableName
WHERE tbl.DatabaseName NOT IN ('All', 'Crashdumps', 'DBC', 'dbcmngr',
'Default', 'External_AP', 'EXTUSER', 'LockLogShredder', 'PUBLIC',
'Sys_Calendar', 'SysAdmin', 'SYSBAR', 'SYSJDBC', 'SYSLIB',
'SystemFe', 'SYSUDTLIB', 'SYSUIF', 'TD_SERVER_DB', 'TDStats',
'TD_SYSGPL', 'TD_SYSXML', 'TDMaps', 'TDPUSER', 'TDQCD',
'tdwm', 'SQLJ', 'TD_SYSFNLIB', 'SYSSPATIAL')
AND TableKind = 'T'
GROUP BY tbl.DatabaseName,
tbl.TableName
ORDER BY TableSize DESC;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782557898
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782061221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135265/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781936759
**[Test build #135262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135262/testReport)** for PR 31548 at commit [`280f39c`](https://github.com/apache/spark/commit/280f39c09d1091da88625ff827b4e828a7f72c01).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777211878
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39691/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778562199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827350379
**[Test build #137988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137988/testReport)** for PR 31548 at commit [`1d4a6b3`](https://github.com/apache/spark/commit/1d4a6b35c90c6f6bdc6b1c684709a0ebe10c1400).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814258562
> Allow creating views with these special commands, e.g. CREATE VIEW v AS SHOW TABLES.
Hmm.. `SHOW TABLES` shows `v` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781905388
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39842/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814835232
**[Test build #137006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137006/testReport)** for PR 31548 at commit [`add16cb`](https://github.com/apache/spark/commit/add16cbfd6181dfb6829fc905a10e82fc4bbc070).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait FunctionRegistryBase[T] `
* `trait SimpleFunctionRegistryBase[T] extends FunctionRegistryBase[T] with Logging `
* `trait EmptyFunctionRegistryBase[T] extends FunctionRegistryBase[T] `
* `trait FunctionRegistry extends FunctionRegistryBase[Expression] `
* `trait TableFunctionRegistry extends FunctionRegistryBase[LogicalPlan] `
* `case class ResolveTableValuedFunctions(catalog: SessionCatalog) extends Rule[LogicalPlan] `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778234218
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777947662
**[Test build #135117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135117/testReport)** for PR 31548 at commit [`23040df`](https://github.com/apache/spark/commit/23040dffe656a27f9b20620ba64ea5bf6d0dca5c).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827525427
ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-801656476
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136195/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-784972265
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135416/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778577690
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135132/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782003893
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782052498
**[Test build #135265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135265/testReport)** for PR 31548 at commit [`7558dcb`](https://github.com/apache/spark/commit/7558dcb1e8ff955865af1e8b13686bec9e65efd2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777963590
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39699/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-784950174
**[Test build #135416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135416/testReport)** for PR 31548 at commit [`8540ccd`](https://github.com/apache/spark/commit/8540ccd96bd026ff5af586917260ffc22f9cc5ad).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781951886
**[Test build #135265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135265/testReport)** for PR 31548 at commit [`7558dcb`](https://github.com/apache/spark/commit/7558dcb1e8ff955865af1e8b13686bec9e65efd2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785071482
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813959315
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136929/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782586562
**[Test build #135303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135303/testReport)** for PR 31548 at commit [`0ac1101`](https://github.com/apache/spark/commit/0ac11011c4975be9a88461ace0cc49e098349c0c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827380749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782003893
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814170427
The use case is totally valid, but we may need more discussion about how to design the API to implement this use case.
I have a few thoughts:
1. Use [information schema](https://en.wikipedia.org/wiki/Information_schema). This is the most standard way, but unfortunately Spark follows Hive and creates a lot of special commands to provide metadata information (e.g. `SHOW TABLES`). It's a lot of effort to switch to information schema in Spark.
2. Allow creating views with these special commands, e.g. `CREATE VIEW v AS SHOW TABLES`.
3. Table-valued command in this function.
Personally I prefer option 2 as it's more predictable. We need extra effort for option 3 to define the behaviors of `FROM COMMAND("abc")` or `FROM COMMAND("DROP TABLE")`, while in option 2 we can carefully change the parser to only allow certain commands in `CREATE VIEW`.
If we want to add information schema in the future, they are read-only views and it's helpful if option 2 is done and we can already create views with SHOW TABLES, etc. already.
What do you think? cc @viirya @maropu @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813959315
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136929/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-801676915
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40777/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827380897
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42508/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782649087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-784975749
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39996/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827380897
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42508/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782648793
**[Test build #135303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135303/testReport)** for PR 31548 at commit [`0ac1101`](https://github.com/apache/spark/commit/0ac11011c4975be9a88461ace0cc49e098349c0c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778562199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778551219
**[Test build #135132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135132/testReport)** for PR 31548 at commit [`ce6f644`](https://github.com/apache/spark/commit/ce6f644a3ae9271eefac1f7215c4873be3a935fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785200868
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135422/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778290250
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781937251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785020408
**[Test build #135422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135422/testReport)** for PR 31548 at commit [`99676ab`](https://github.com/apache/spark/commit/99676abdf15295d87b85082c6625a019a801898e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782591468
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39883/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-784951239
**[Test build #135416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135416/testReport)** for PR 31548 at commit [`8540ccd`](https://github.com/apache/spark/commit/8540ccd96bd026ff5af586917260ffc22f9cc5ad).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778605560
cc @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-784997993
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39996/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785200868
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135422/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782554725
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782649087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31548:
URL: https://github.com/apache/spark/pull/31548#discussion_r576549327
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedCommands.scala
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.analysis
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.catalyst.parser.CatalystSqlParser
+import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, ShowColumns, ShowNamespaces, ShowPartitions, ShowTableProperties, ShowTables}
+import org.apache.spark.sql.catalyst.rules.Rule
+
+/**
+ * Rule that resolves table-valued command references.
+ */
+object ResolveTableValuedCommands extends Rule[LogicalPlan] {
+
+ private def isSupportedCommand(plan: LogicalPlan): Boolean = plan match {
+ case ShowNamespaces(_, _, _) => true
+ case ShowTables(_, _, _) => true
+ case ShowTableProperties(_, _, _) => true
+ case ShowPartitions(_, _, _) => true
+ case ShowColumns(_, _, _) => true
+ // TODO case ShowViews(_, _, _) => true
Review comment:
Can we file a JIRA and make it id'ed todo? e.g) `TODO(SPARK-XXXX): blah blah`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813822372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777211878
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39691/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-822257811
**[Test build #137585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137585/testReport)** for PR 31548 at commit [`add16cb`](https://github.com/apache/spark/commit/add16cbfd6181dfb6829fc905a10e82fc4bbc070).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-784972265
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135416/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-784950174
**[Test build #135416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135416/testReport)** for PR 31548 at commit [`8540ccd`](https://github.com/apache/spark/commit/8540ccd96bd026ff5af586917260ffc22f9cc5ad).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777933907
**[Test build #135117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135117/testReport)** for PR 31548 at commit [`23040df`](https://github.com/apache/spark/commit/23040dffe656a27f9b20620ba64ea5bf6d0dca5c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814636104
**[Test build #137006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137006/testReport)** for PR 31548 at commit [`add16cb`](https://github.com/apache/spark/commit/add16cbfd6181dfb6829fc905a10e82fc4bbc070).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814759457
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41584/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813806572
**[Test build #136929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136929/testReport)** for PR 31548 at commit [`399b028`](https://github.com/apache/spark/commit/399b028023ba15656734f59d92831258fb7d45df).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-822377543
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137585/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777186016
**[Test build #135109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135109/testReport)** for PR 31548 at commit [`cf6ca82`](https://github.com/apache/spark/commit/cf6ca820ee365bd8857265574b6fa269db203e75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814759517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782576171
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135287/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782561705
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778232245
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135124/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785008339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39996/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-790246635
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778207764
**[Test build #135124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135124/testReport)** for PR 31548 at commit [`6bdeb3e`](https://github.com/apache/spark/commit/6bdeb3e98547f2c07858457659ec852bffcdcc5e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782591824
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39883/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813824165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41506/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813824165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41506/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31548:
URL: https://github.com/apache/spark/pull/31548#discussion_r578069371
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedCommands.scala
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.analysis
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.catalyst.parser.CatalystSqlParser
+import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, ShowColumns, ShowNamespaces, ShowPartitions, ShowTableProperties, ShowTables}
+import org.apache.spark.sql.catalyst.rules.Rule
+
+/**
+ * Rule that resolves table-valued command references.
+ */
+object ResolveTableValuedCommands extends Rule[LogicalPlan] {
+
+ private def isSupportedCommand(plan: LogicalPlan): Boolean = plan match {
+ case ShowNamespaces(_, _, _) => true
+ case ShowTables(_, _, _) => true
+ case ShowTableProperties(_, _, _) => true
+ case ShowPartitions(_, _, _) => true
+ case ShowColumns(_, _, _) => true
+ // TODO case ShowViews(_, _, _) => true
Review comment:
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785199324
**[Test build #135422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135422/testReport)** for PR 31548 at commit [`99676ab`](https://github.com/apache/spark/commit/99676abdf15295d87b85082c6625a019a801898e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827534182
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137988/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778559603
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782575302
**[Test build #135287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135287/testReport)** for PR 31548 at commit [`2eeb9d7`](https://github.com/apache/spark/commit/2eeb9d7dd0aa23cfddb0babe710dfb3352b16383).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781923639
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39842/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785020408
**[Test build #135422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135422/testReport)** for PR 31548 at commit [`99676ab`](https://github.com/apache/spark/commit/99676abdf15295d87b85082c6625a019a801898e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814837103
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137006/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-822257811
**[Test build #137585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137585/testReport)** for PR 31548 at commit [`add16cb`](https://github.com/apache/spark/commit/add16cbfd6181dfb6829fc905a10e82fc4bbc070).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31548:
URL: https://github.com/apache/spark/pull/31548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781951886
**[Test build #135265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135265/testReport)** for PR 31548 at commit [`7558dcb`](https://github.com/apache/spark/commit/7558dcb1e8ff955865af1e8b13686bec9e65efd2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778551219
**[Test build #135132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135132/testReport)** for PR 31548 at commit [`ce6f644`](https://github.com/apache/spark/commit/ce6f644a3ae9271eefac1f7215c4873be3a935fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814744497
> Ah good point. One way is to eagerly execute the command when creating the view, so `v` is excluded from the result, but it's a bit tricky to make the view not lazy.
>
> Another idea is to allow SHOW TABLES etc. as subqueries, e.g. `SELECT ... FROM (SHOW TABLES)`.
Making a non lazy view sounds weird to me. We then create another kind of special view just for this kind of commands.
The subquery approach looks more promising to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785071482
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777963590
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39699/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782547075
**[Test build #135287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135287/testReport)** for PR 31548 at commit [`2eeb9d7`](https://github.com/apache/spark/commit/2eeb9d7dd0aa23cfddb0babe710dfb3352b16383).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781887505
**[Test build #135262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135262/testReport)** for PR 31548 at commit [`280f39c`](https://github.com/apache/spark/commit/280f39c09d1091da88625ff827b4e828a7f72c01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782561705
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813948093
**[Test build #136929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136929/testReport)** for PR 31548 at commit [`399b028`](https://github.com/apache/spark/commit/399b028023ba15656734f59d92831258fb7d45df).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782586562
**[Test build #135303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135303/testReport)** for PR 31548 at commit [`0ac1101`](https://github.com/apache/spark/commit/0ac11011c4975be9a88461ace0cc49e098349c0c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814282105
> SHOW TABLES shows v here?
Ah good point. One way is to eagerly execute the command when creating the view, so `v` is excluded from the result, but it's a bit tricky to make the view not lazy.
Another idea is to allow SHOW TABLES etc. as subqueries, e.g. `SELECT ... FROM (SHOW TABLES)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778577690
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135132/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #31548:
URL: https://github.com/apache/spark/pull/31548#discussion_r578100090
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -136,6 +136,29 @@ case class UnresolvedTableValuedFunction(
override lazy val resolved = false
}
+/**
+ * A table-valued command, e.g.
+ * {{{
+ * select tableName from command("show tables");
Review comment:
First, this PR references the table-valued-function. So, I call the syntax is table-valued-command.
Second, Users want use filter clause, group by, ... on table-valued-command. In fact, This PR adopt the syntax-based approach is much simpler than built-in function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782547075
**[Test build #135287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135287/testReport)** for PR 31548 at commit [`2eeb9d7`](https://github.com/apache/spark/commit/2eeb9d7dd0aa23cfddb0babe710dfb3352b16383).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785064024
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777196280
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135109/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-783283377
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781887505
**[Test build #135262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135262/testReport)** for PR 31548 at commit [`280f39c`](https://github.com/apache/spark/commit/280f39c09d1091da88625ff827b4e828a7f72c01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #31548:
URL: https://github.com/apache/spark/pull/31548#discussion_r576611589
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedCommands.scala
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.analysis
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.catalyst.parser.CatalystSqlParser
+import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, ShowColumns, ShowNamespaces, ShowPartitions, ShowTableProperties, ShowTables}
+import org.apache.spark.sql.catalyst.rules.Rule
+
+/**
+ * Rule that resolves table-valued command references.
+ */
+object ResolveTableValuedCommands extends Rule[LogicalPlan] {
+
+ private def isSupportedCommand(plan: LogicalPlan): Boolean = plan match {
+ case ShowNamespaces(_, _, _) => true
+ case ShowTables(_, _, _) => true
+ case ShowTableProperties(_, _, _) => true
+ case ShowPartitions(_, _, _) => true
+ case ShowColumns(_, _, _) => true
+ // TODO case ShowViews(_, _, _) => true
Review comment:
If https://github.com/apache/spark/pull/31508 and https://github.com/apache/spark/pull/31519 before this PR merged, I will implement the code. Otherwise, I will create two tickets later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777196280
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135109/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777189983
**[Test build #135109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135109/testReport)** for PR 31548 at commit [`cf6ca82`](https://github.com/apache/spark/commit/cf6ca820ee365bd8857265574b6fa269db203e75).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777947800
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827350379
**[Test build #137988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137988/testReport)** for PR 31548 at commit [`1d4a6b3`](https://github.com/apache/spark/commit/1d4a6b35c90c6f6bdc6b1c684709a0ebe10c1400).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778575052
**[Test build #135132 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135132/testReport)** for PR 31548 at commit [`ce6f644`](https://github.com/apache/spark/commit/ce6f644a3ae9271eefac1f7215c4873be3a935fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814636104
**[Test build #137006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137006/testReport)** for PR 31548 at commit [`add16cb`](https://github.com/apache/spark/commit/add16cbfd6181dfb6829fc905a10e82fc4bbc070).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-822377543
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137585/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-801676915
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40777/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777947800
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782061221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135265/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-814759517
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41584/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827534182
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137988/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778302001
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-893906332
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777186016
**[Test build #135109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135109/testReport)** for PR 31548 at commit [`cf6ca82`](https://github.com/apache/spark/commit/cf6ca820ee365bd8857265574b6fa269db203e75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778232245
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135124/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778768282
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778555727
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-827524019
**[Test build #137988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137988/testReport)** for PR 31548 at commit [`1d4a6b3`](https://github.com/apache/spark/commit/1d4a6b35c90c6f6bdc6b1c684709a0ebe10c1400).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-801656476
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136195/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782590831
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39883/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31548:
URL: https://github.com/apache/spark/pull/31548#discussion_r578077671
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -136,6 +136,29 @@ case class UnresolvedTableValuedFunction(
override lazy val resolved = false
}
+/**
+ * A table-valued command, e.g.
+ * {{{
+ * select tableName from command("show tables");
Review comment:
We cannot add a new built-in function for this purpose instead? The implementation will be simpler than the current syntax-based approach, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-813806572
**[Test build #136929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136929/testReport)** for PR 31548 at commit [`399b028`](https://github.com/apache/spark/commit/399b028023ba15656734f59d92831258fb7d45df).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785008339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39996/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-781937244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782576171
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135287/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-782591824
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39883/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778302001
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-785048683
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-777933907
**[Test build #135117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135117/testReport)** for PR 31548 at commit [`23040df`](https://github.com/apache/spark/commit/23040dffe656a27f9b20620ba64ea5bf6d0dca5c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778207764
**[Test build #135124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135124/testReport)** for PR 31548 at commit [`6bdeb3e`](https://github.com/apache/spark/commit/6bdeb3e98547f2c07858457659ec852bffcdcc5e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31548: [SPARK-34127][SQL] Support table valued command
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31548:
URL: https://github.com/apache/spark/pull/31548#issuecomment-778208815
**[Test build #135124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135124/testReport)** for PR 31548 at commit [`6bdeb3e`](https://github.com/apache/spark/commit/6bdeb3e98547f2c07858457659ec852bffcdcc5e).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org