You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by sakanaou <gi...@git.apache.org> on 2017/08/23 14:29:51 UTC
[GitHub] storm pull request #2292: STORM-2705: DRPCSpout sleeps twice
GitHub user sakanaou opened a pull request:
https://github.com/apache/storm/pull/2292
STORM-2705: DRPCSpout sleeps twice
When the `DRPCSpout` cannot fetch a request it puts itself to sleep at the end of `nextTuple()`. After leaving this method the case that the spout did not emit any tuple is handled by `ISpoutWaitStrategy` - which in case of `SleepSpoutWaitStrategy` (the default) issues another sleep.
This causes unnecessary context switches in my opinion, especially with a high parallelism setting and many different `DRPCSpout`s.
Only the configured / active `ISpoutWaitStrategy` should decide the action.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sakanaou/storm STORM-2705
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2292
----
commit 84e14f6cf4cd38594b966f6069b92436eaa1f2a2
Author: sakanaou <sa...@users.noreply.github.com>
Date: 2017-08-23T14:23:58Z
STORM-2705: DRPCSpout should not sleep itself if no request was fetched
as the ISpoutWaitStrategy handles this case.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2292: STORM-2705: DRPCSpout sleeps twice
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2292
+1 to master branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2292: STORM-2705: DRPCSpout sleeps twice
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2292: STORM-2705: DRPCSpout sleeps twice
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2292
+1 again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2292: STORM-2705: DRPCSpout sleeps twice
Posted by sakanaou <gi...@git.apache.org>.
Github user sakanaou commented on the issue:
https://github.com/apache/storm/pull/2292
Ok, I will update the PR so it can be applied to master easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---