You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:43:21 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #7803: ARROW-9517: [C++/Python] Add optional session_token to S3Options

kszucs commented on a change in pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#discussion_r461493406



##########
File path: cpp/src/arrow/filesystem/s3fs.h
##########
@@ -62,10 +62,12 @@ struct ARROW_EXPORT S3Options {
   void ConfigureAnonymousCredentials();
 
   /// Configure with explicit access and secret key.
-  void ConfigureAccessKey(const std::string& access_key, const std::string& secret_key);
+  void ConfigureAccessKey(const std::string& access_key, const std::string& secret_key,
+                          const std::string& session_token = "");
 
   std::string GetAccessKey() const;
   std::string GetSecretKey() const;
+  std::string GetSessionToken() const;

Review comment:
       Please cover the new API with tests on the C++ side.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org