You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "kevinw66 (via GitHub)" <gi...@apache.org> on 2023/05/17 07:45:09 UTC

[GitHub] [bigtop] kevinw66 opened a new pull request, #1112: BIGTOP-3944: Enable squash and merge

kevinw66 opened a new pull request, #1112:
URL: https://github.com/apache/bigtop/pull/1112

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
   -->
   
   ### Description of PR
   
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
   - [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] kevinw66 commented on pull request #1112: BIGTOP-3944: Enable squash and merge

Posted by "kevinw66 (via GitHub)" <gi...@apache.org>.
kevinw66 commented on PR #1112:
URL: https://github.com/apache/bigtop/pull/1112#issuecomment-1708672548

   > @kevinw66 You intend to allow only `Squash and merge` by disabling `Create a merge commit` and `Rebase and merge`?
   
   @iwasakims Yes, since we need to `rebase` before merging anyway, it might be easier to just allow `Squash and merge`, which can also avoid potential operational mistakes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] iwasakims commented on pull request #1112: BIGTOP-3944: Enable squash and merge

Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1112:
URL: https://github.com/apache/bigtop/pull/1112#issuecomment-1708239653

   @kevinw66 You intend to allow only `Squash and merge` by disabling `Create a merge commit` and `Rebase and merge`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] iwasakims merged pull request #1112: BIGTOP-3944: Enable squash and merge

Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims merged PR #1112:
URL: https://github.com/apache/bigtop/pull/1112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org