[GitHub] [airflow] uranusjr commented on a change in pull request #22683: Correctly apply defaults to mapped task flow

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #22683:
URL: https://github.com/apache/airflow/pull/22683#discussion_r840437617



##########
File path: airflow/decorators/base.py
##########
@@ -305,13 +311,21 @@ def expand(self, **map_kwargs: "Mappable") -> XComArg:
         prevent_duplicates(self.kwargs, map_kwargs, fail_reason="mapping already partial")
         ensure_xcomarg_return_value(map_kwargs)
 
-        partial_kwargs = self.kwargs.copy()
+        task_kwargs = self.kwargs.copy()
+        dag = task_kwargs.pop("dag", None) or DagContext.get_current_dag()
+        task_group = task_kwargs.pop("task_group", None) or TaskGroupContext.get_current_task_group(dag)
+
+        partial_kwargs, default_params = get_merged_defaults(
+            dag=dag,
+            task_group=task_group,
+            task_params=task_kwargs.pop("params", None),
+            task_default_args=task_kwargs.pop("default_args", None),

Review comment:
       It actually is, there’s a `default_args` argument on BaseOperator.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org