[GitHub] [incubator-inlong] kipshi commented on a change in pull request #3393: [INLONG-3392] Optimize listGroupState in ManagerClient

[GitBox <gi...@apache.org>]

kipshi commented on a change in pull request #3393:
URL: https://github.com/apache/incubator-inlong/pull/3393#discussion_r836138062



##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongClientImpl.java
##########
@@ -129,11 +129,11 @@ public InlongGroup forGroup(InlongGroupConf groupConf) {
         List<InlongGroupListResponse> groupListResponses = pageInfoResponse.getData().getList();
         Map<String, InlongGroupState> groupStateMap = Maps.newHashMap();
         groupListResponses.stream().forEach(groupListResponse -> {
-            String groupId = groupListResponse.getInlongGroupId();
+            String groupName = groupListResponse.getName();

Review comment:
       Name is recommend as unique key for inlong group, id is  a concept which is not universally used




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org