You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/03/31 13:32:25 UTC

[jira] Created: (QPID-886) CSDM.removeExpired() doesn't relinquish lock causing broker hang.

CSDM.removeExpired() doesn't relinquish lock causing broker hang.
-----------------------------------------------------------------

                 Key: QPID-886
                 URL: https://issues.apache.org/jira/browse/QPID-886
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
    Affects Versions: M2, M2.1
            Reporter: Martin Ritchie
            Priority: Critical


Summary:

The removeExpired mesages grabs the delivery _lock but doesn't use a finally to remove it so if an exception occurs then the lock can be lost and the system hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-886) CSDM.removeExpired() doesn't relinquish lock causing broker hang.

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner resolved QPID-886.
--------------------------------

    Resolution: Fixed

CSDM is dead, long live not having CSDM!

> CSDM.removeExpired() doesn't relinquish lock causing broker hang.
> -----------------------------------------------------------------
>
>                 Key: QPID-886
>                 URL: https://issues.apache.org/jira/browse/QPID-886
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2, M2.1
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Blocker
>             Fix For: M3
>
>         Attachments: QPID-886-LockRelease.patch
>
>   Original Estimate: 2h
>          Time Spent: 0.17h
>  Remaining Estimate: 1.83h
>
> Summary:
> The removeExpired mesages grabs the delivery _lock but doesn't use a finally to remove it so if an exception occurs then the lock can be lost and the system hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-886) CSDM.removeExpired() doesn't relinquish lock causing broker hang.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-886:
-----------------------------------

    Assignee: Martin Ritchie

> CSDM.removeExpired() doesn't relinquish lock causing broker hang.
> -----------------------------------------------------------------
>
>                 Key: QPID-886
>                 URL: https://issues.apache.org/jira/browse/QPID-886
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2, M2.1
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Critical
>             Fix For: M2.1
>
>         Attachments: QPID-886-LockRelease.patch
>
>
> Summary:
> The removeExpired mesages grabs the delivery _lock but doesn't use a finally to remove it so if an exception occurs then the lock can be lost and the system hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-886) CSDM.removeExpired() doesn't relinquish lock causing broker hang.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-886:
--------------------------------

    Attachment: QPID-886-LockRelease.patch

> CSDM.removeExpired() doesn't relinquish lock causing broker hang.
> -----------------------------------------------------------------
>
>                 Key: QPID-886
>                 URL: https://issues.apache.org/jira/browse/QPID-886
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2, M2.1
>            Reporter: Martin Ritchie
>            Priority: Critical
>         Attachments: QPID-886-LockRelease.patch
>
>
> Summary:
> The removeExpired mesages grabs the delivery _lock but doesn't use a finally to remove it so if an exception occurs then the lock can be lost and the system hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-886) CSDM.removeExpired() doesn't relinquish lock causing broker hang.

Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621756#action_12621756 ] 

Rob Godfrey commented on QPID-886:
----------------------------------

Since the CSDM was removed by QPID-950, this issue and patch have been effectively overtaken by events for M3

> CSDM.removeExpired() doesn't relinquish lock causing broker hang.
> -----------------------------------------------------------------
>
>                 Key: QPID-886
>                 URL: https://issues.apache.org/jira/browse/QPID-886
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2, M2.1
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Blocker
>             Fix For: M3
>
>         Attachments: QPID-886-LockRelease.patch
>
>   Original Estimate: 2h
>          Time Spent: 0.17h
>  Remaining Estimate: 1.83h
>
> Summary:
> The removeExpired mesages grabs the delivery _lock but doesn't use a finally to remove it so if an exception occurs then the lock can be lost and the system hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-886) CSDM.removeExpired() doesn't relinquish lock causing broker hang.

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner updated QPID-886:
-------------------------------

    Fix Version/s:     (was: M2.1)
                   M3

> CSDM.removeExpired() doesn't relinquish lock causing broker hang.
> -----------------------------------------------------------------
>
>                 Key: QPID-886
>                 URL: https://issues.apache.org/jira/browse/QPID-886
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2, M2.1
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Blocker
>             Fix For: M3
>
>         Attachments: QPID-886-LockRelease.patch
>
>   Original Estimate: 2h
>          Time Spent: 0.17h
>  Remaining Estimate: 1.83h
>
> Summary:
> The removeExpired mesages grabs the delivery _lock but doesn't use a finally to remove it so if an exception occurs then the lock can be lost and the system hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-886) CSDM.removeExpired() doesn't relinquish lock causing broker hang.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-886:
--------------------------------

              Priority: Blocker  (was: Critical)
         Fix Version/s: M2.1
    Remaining Estimate: 2h
     Original Estimate: 2h

We should really fix this for the M2.1 release.

> CSDM.removeExpired() doesn't relinquish lock causing broker hang.
> -----------------------------------------------------------------
>
>                 Key: QPID-886
>                 URL: https://issues.apache.org/jira/browse/QPID-886
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2, M2.1
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Blocker
>             Fix For: M2.1
>
>         Attachments: QPID-886-LockRelease.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Summary:
> The removeExpired mesages grabs the delivery _lock but doesn't use a finally to remove it so if an exception occurs then the lock can be lost and the system hang.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.