[GitHub] [flink] luoyuxia commented on a diff in pull request #18958: [FLINK-15854][hive] Use the new type inference for Hive UDTF

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #18958:
URL: https://github.com/apache/flink/pull/18958#discussion_r888005853


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserCalcitePlanner.java:
##########
@@ -2539,9 +2539,9 @@ private RelNode genUDTFPlan(
 
         SqlOperator convertedOperator = convertedCall.getOperator();
         Preconditions.checkState(
-                convertedOperator instanceof SqlUserDefinedTableFunction,
+                convertedOperator instanceof BridgingSqlFunction,
                 "Expect operator to be "
-                        + SqlUserDefinedTableFunction.class.getSimpleName()
+                        + BridgingSqlFunction.class.getSimpleName()

Review Comment:
   Before this pr, the Hive's udtf will be converted to `HiveTableSqlFunction`, which is instance of SqlUserDefinedTableFunction. The old code logic is in  [here](https://github.com/apache/flink/pull/18958/files#diff-ca5db8275fd03a414acc2af23a9114f47791506fb0542986f55f31865f1dbb87L130).
   After this pr, it'll then convert to `BridgingSqlFunction`.
   So, we need to.change it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org