You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 16:37:12 UTC
[GitHub] [airflow] ashb opened a new pull request #12070: If we build a new image, we should run more than basic checks
ashb opened a new pull request #12070:
URL: https://github.com/apache/airflow/pull/12070
This lead to bases such as in #11699 where despite there being changes, and an image being build, the pre-commit tests were not being run.
This looks like maybe you spotted the error Jarek, but never pushed the fix before merging it: https://github.com/apache/airflow/pull/12038#discussion_r515950284
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #12070: If we build a new image, we should run more than basic checks
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #12070:
URL: https://github.com/apache/airflow/pull/12070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12070: If we build a new image, we should run more than basic checks
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12070:
URL: https://github.com/apache/airflow/pull/12070#issuecomment-721278641
(Going to merge this -- can fix up later if it's wrong.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org