You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sethah <gi...@git.apache.org> on 2016/03/10 01:53:40 UTC

[GitHub] spark pull request: [SPARK-13787][ML][PYSPARK] Pyspark feature imp...

GitHub user sethah opened a pull request:

    https://github.com/apache/spark/pull/11622

    [SPARK-13787][ML][PYSPARK] Pyspark feature importances for decision tree and random forest

    ## What changes were proposed in this pull request?
    
    This patch adds a `featureImportance` property to the Pyspark API for `DecisionTreeRegressionModel`, `DecisionTreeClassificationModel`, `RandomForestRegressionModel` and `RandomForestClassificationModel`.
    
    
    ## How was this patch tested?
    
    Python doc tests for the affected classes were updated to check feature importances.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sethah/spark SPARK-13787

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11622
    
----
commit 9cbe8ea8bfd9a486129bcb15821e2cdc4c691cff
Author: sethah <se...@gmail.com>
Date:   2016-03-09T23:38:19Z

    adding feature importances for decision tree and random forest

commit 6226cd40ae2ec4206d2a45b3fcd0d58cb2e0ebb8
Author: sethah <se...@gmail.com>
Date:   2016-03-10T00:34:31Z

    adding links

commit d1a5a7e60b0ecf6d7f7ebce3aa6c0663a09f71a5
Author: sethah <se...@gmail.com>
Date:   2016-03-10T00:46:48Z

    adding doctests

commit f1307a3324566534f8714288ff8004cbb2ccfb47
Author: sethah <se...@gmail.com>
Date:   2016-03-10T00:49:01Z

    fixing typo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13787][ML][PYSPARK] Pyspark feature imp...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11622#issuecomment-194601169
  
    **[Test build #52789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52789/consoleFull)** for PR 11622 at commit [`f1307a3`](https://github.com/apache/spark/commit/f1307a3324566534f8714288ff8004cbb2ccfb47).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13787][ML][PYSPARK] Pyspark feature imp...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11622#issuecomment-194601284
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52789/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13787][ML][PYSPARK] Pyspark feature imp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/11622


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13787][ML][PYSPARK] Pyspark feature imp...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11622#issuecomment-194601281
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13787][ML][PYSPARK] Pyspark feature imp...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11622#issuecomment-194596378
  
    **[Test build #52789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52789/consoleFull)** for PR 11622 at commit [`f1307a3`](https://github.com/apache/spark/commit/f1307a3324566534f8714288ff8004cbb2ccfb47).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-13787][ML][PYSPARK] Pyspark feature imp...

Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the pull request:

    https://github.com/apache/spark/pull/11622#issuecomment-195240750
  
    LGTM - merged to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org