You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2020/10/12 15:16:15 UTC

[isis-app-simpleapp] branch master updated: reactivate cucumber reporting plugin

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis-app-simpleapp.git


The following commit(s) were added to refs/heads/master by this push:
     new 18a8ab9  reactivate cucumber reporting plugin
18a8ab9 is described below

commit 18a8ab98990b04888aa3fec8c3c583d4340e5bf1
Author: Andi Huber <ah...@apache.org>
AuthorDate: Mon Oct 12 17:16:02 2020 +0200

    reactivate cucumber reporting plugin
---
 webapp/pom.xml                                     | 46 +++++++++++-----------
 .../src/test/resources/junit-platform.properties   | 14 ++-----
 2 files changed, 26 insertions(+), 34 deletions(-)

diff --git a/webapp/pom.xml b/webapp/pom.xml
index 06349ff..2deb285 100644
--- a/webapp/pom.xml
+++ b/webapp/pom.xml
@@ -54,29 +54,29 @@
             </testResource>
         </testResources>
         <plugins>
-<!--             <plugin> -->
-<!--                 <groupId>net.masterthought</groupId> -->
-<!--                 <artifactId>maven-cucumber-reporting</artifactId> -->
-<!--                 <version>${maven-cucumber-reporting.version}</version> -->
-<!--                 <executions> -->
-<!--                     <execution> -->
-<!--                         <id>default</id> -->
-<!--                         <phase>post-integration-test</phase> -->
-<!--                         <goals> -->
-<!--                             <goal>generate</goal> -->
-<!--                         </goals> -->
-<!--                         <configuration> -->
-<!--                             <projectName>SimpleApp</projectName> -->
-<!--                             <outputDirectory>${project.build.directory}</outputDirectory> -->
-<!--                             <inputDirectory>${project.build.directory}</inputDirectory> -->
-<!--                             <jsonFiles> -->
-<!--                                 <param>**/cucumber-no-clobber.json</param> -->
-<!--                             </jsonFiles> -->
-<!--                             <skip>${skipBDD}</skip> -->
-<!--                         </configuration> -->
-<!--                     </execution> -->
-<!--                 </executions> -->
-<!--             </plugin> -->
+            <plugin>
+                <groupId>net.masterthought</groupId>
+                <artifactId>maven-cucumber-reporting</artifactId>
+                <version>${maven-cucumber-reporting.version}</version>
+                <executions>
+                    <execution>
+                        <id>default</id>
+                        <phase>post-integration-test</phase>
+                        <goals>
+                            <goal>generate</goal>
+                        </goals>
+                        <configuration>
+                            <projectName>SimpleApp</projectName>
+                            <outputDirectory>${project.build.directory}</outputDirectory>
+                            <inputDirectory>${project.build.directory}</inputDirectory>
+                            <jsonFiles>
+                                <param>**/cucumber-report.json</param>
+                            </jsonFiles>
+                            <skip>${skipBDD}</skip>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
             <!-- running: mvn spring-boot:run -->
             <plugin>
                 <groupId>org.springframework.boot</groupId>
diff --git a/webapp/src/test/resources/junit-platform.properties b/webapp/src/test/resources/junit-platform.properties
index 86a8596..1a02b70 100644
--- a/webapp/src/test/resources/junit-platform.properties
+++ b/webapp/src/test/resources/junit-platform.properties
@@ -1,15 +1,7 @@
 # as per https://github.com/cucumber/cucumber-jvm/tree/master/junit-platform-engine#configuration-options
 cucumber.publish.quiet=true
 cucumber.filter.tags=not @backlog and not @ignore
+#we are using @Cucumber annotated classes and restrict classpath search to
 cucumber.glue=domainapp.webapp.bdd
-#we are using @Cucumber annotated classes instead
-
-# WARNING:
-#
-# cucumber.plugins=json:target/cucumber.json
-#
-# will cause an empty file to be created when running from mvn.
-#
-# this is why the maven configuration to execute cucumber using the CLI (antrun:run@cucumber-cli)
-# is configured to use --plugins json:target/cucumber-no-clobber.json, just in case.
-#
\ No newline at end of file
+#we are using built-in reporting plugins
+cucumber.plugin=pretty, json:target/cucumber-reports/cucumber-report.json, html:target/cucumber-reports/cucumber-report.html