[GitHub] [helix] alirezazamani commented on pull request #1221: (WIP) Drop the task related current states for new session

[GitBox <gi...@apache.org>]

alirezazamani commented on pull request #1221:
URL: https://github.com/apache/helix/pull/1221#issuecomment-670716214


   > Another thing, if we directly drop current state, shall we have some mechanism in the participant side to cancel all running tasks before we reset all the thread pool? If there are some data need to be cleared.
   
   I just checked the HelixStateMachineEngine file. When we call reset() in this file, for the tasks we call       _taskRunner.cancel() which cancels the tasks on the participant. So I think if we skip the currentState carry over operation for the tasks, we are good to go. Please let me know if that answers your questions. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org