[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6413: add global setting to allow parallel execution on vmware

[GitBox <gi...@apache.org>]

weizhouapache commented on code in PR #6413:
URL: https://github.com/apache/cloudstack/pull/6413#discussion_r883651773


##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -163,6 +163,22 @@ public interface StorageManager extends StorageService {
             true,
             ConfigKey.Scope.Cluster,
             null);
+    ConfigKey<Boolean> VmwareCreateCloneFull = new ConfigKey<>(Boolean.class,
+            "vmware.create.full.clone",
+            "Storage",
+            "false",
+            "If set to true, creates VMs as full clones on ESX hypervisor",
+            true,
+            ConfigKey.Scope.StoragePool,
+            null);
+    ConfigKey<Boolean> vmwareAllowParallelExecution = new ConfigKey<>(Boolean.class,
+            "vmware.allow.parallel.copy.command.execution",
+            "Advanced",
+            "false",
+            "allow copy command to be executed in parallel in spite of 'vmware.create.full.clone' being set to false.",

Review Comment:
   @DaanHoogland 
   will other commands than CopyCommand be impacted ?
   from source code, it looks yes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org