You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/19 19:41:00 UTC
[GitHub] [geode] jhutchison opened a new pull request #6160: GEODE-9001: Update Documents to be match recent code changes in compa…
jhutchison opened a new pull request #6160:
URL: https://github.com/apache/geode/pull/6160
…tible-with-redis commands
(cherry picked from commit 58116cc759076ee093ec1627795cae431a0b7265)
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on pull request #6160: GEODE-9001: Update Documents to be match recent code changes in compatible-with-redis commands
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on pull request #6160:
URL: https://github.com/apache/geode/pull/6160#issuecomment-807661356
> @jhutchison this commit and the develop commit from which it has been cherry picked, differ a bit. This commit is missing the geode-redis/README.md file. Is it expected?
I fixed the README to match what is currently supported in 1.14. It may need to be updated as we backport more stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jhutchison commented on pull request #6160: GEODE-9001: Update Documents to be match recent code changes in compatible-with-redis commands
Posted by GitBox <gi...@apache.org>.
jhutchison commented on pull request #6160:
URL: https://github.com/apache/geode/pull/6160#issuecomment-807046813
> @jhutchison this commit and the develop commit from which it has been cherry picked, differ a bit. This commit is missing the geode-redis/README.md file. Is it expected?
Yes, there was a merge conflict in the cherry pick and I decided to just rollback the changes and include them when we make major changes to the readme. If this goes against our process let me know and I can go through the work of resolving the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jhutchison edited a comment on pull request #6160: GEODE-9001: Update Documents to be match recent code changes in compatible-with-redis commands
Posted by GitBox <gi...@apache.org>.
jhutchison edited a comment on pull request #6160:
URL: https://github.com/apache/geode/pull/6160#issuecomment-807046813
> @jhutchison this commit and the develop commit from which it has been cherry picked, differ a bit. This commit is missing the geode-redis/README.md file. Is it expected?
Yes, there was a merge conflict in the cherry pick and I decided to just rollback the changes and include them when we make major changes to the readme. If this goes against our processes- or just seems like a bad idea- let me know and I can go through the work of resolving the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag merged pull request #6160: GEODE-9001: Update Documents to be match recent code changes in compatible-with-redis commands
Posted by GitBox <gi...@apache.org>.
nabarunnag merged pull request #6160:
URL: https://github.com/apache/geode/pull/6160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag commented on pull request #6160: GEODE-9001: Update Documents to be match recent code changes in compatible-with-redis commands
Posted by GitBox <gi...@apache.org>.
nabarunnag commented on pull request #6160:
URL: https://github.com/apache/geode/pull/6160#issuecomment-804220708
@jhutchison this commit and the develop commit from which it has been cherry picked, differ a bit. This commit is missing the geode-redis/README.md file. Is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jhutchison edited a comment on pull request #6160: GEODE-9001: Update Documents to be match recent code changes in compatible-with-redis commands
Posted by GitBox <gi...@apache.org>.
jhutchison edited a comment on pull request #6160:
URL: https://github.com/apache/geode/pull/6160#issuecomment-807046813
> @jhutchison this commit and the develop commit from which it has been cherry picked, differ a bit. This commit is missing the geode-redis/README.md file. Is it expected?
Yes, there was a merge conflict in the cherry pick and I decided to just rollback the changes in the readme and include them when we make major changes to the that file soon. If this goes against our processes- or just seems like a bad idea- let me know and I can go through the work of resolving the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org