You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/04 09:58:33 UTC

[GitHub] [nifi] CZuegner opened a new pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method

CZuegner opened a new pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method
URL: https://github.com/apache/nifi/pull/4034
 
 
   Some jdbc drivers e.g. Oracle returns java.sql.Array objects for array types, not just Lists.
   This commit also handles these cases, and extracts the primitive java arrays out of this jdbc holder class.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] pvillard31 commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method
URL: https://github.com/apache/nifi/pull/4034#discussion_r374947530
 
 

 ##########
 File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
 ##########
 @@ -128,7 +128,7 @@ protected Record createRecord(final ResultSet rs) throws SQLException {
     }
 
     @SuppressWarnings("rawtypes")
-    private Object normalizeValue(final Object value) {
+    private Object normalizeValue(final Object value) throws SQLException {
 
 Review comment:
   My bad, I didn't notice it was about ``java.sql.Array``

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] asfgit closed pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method
URL: https://github.com/apache/nifi/pull/4034
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] pvillard31 commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method
URL: https://github.com/apache/nifi/pull/4034#discussion_r374911915
 
 

 ##########
 File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
 ##########
 @@ -128,7 +128,7 @@ protected Record createRecord(final ResultSet rs) throws SQLException {
     }
 
     @SuppressWarnings("rawtypes")
-    private Object normalizeValue(final Object value) {
+    private Object normalizeValue(final Object value) throws SQLException {
 
 Review comment:
   Is this change necessary at all?
   ```suggestion
       private Object normalizeValue(final Object value) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] davidvoit commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method

Posted by GitBox <gi...@apache.org>.
davidvoit commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method
URL: https://github.com/apache/nifi/pull/4034#discussion_r374936740
 
 

 ##########
 File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
 ##########
 @@ -128,7 +128,7 @@ protected Record createRecord(final ResultSet rs) throws SQLException {
     }
 
     @SuppressWarnings("rawtypes")
-    private Object normalizeValue(final Object value) {
+    private Object normalizeValue(final Object value) throws SQLException {
 
 Review comment:
   The getArray() call is throwing this, so yes we need to rethrow the error or try catch it.
   As createRecord is already handling this, and createrecord is the only place where normalizeValue is called, this looks correct to me. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services