You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "bayars (via GitHub)" <gi...@apache.org> on 2026/01/26 23:24:32 UTC
[PR] GUACAMOLE-519: Openid Single Logout Docs [guacamole-manual]
bayars opened a new pull request, #280:
URL: https://github.com/apache/guacamole-manual/pull/280
Hey!
This is merged on the gucamole client yesterday.
This MR created just for documentation updates for this [MR](https://github.com/apache/guacamole-client/pull/1149).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-519: Openid Single Logout Docs [guacamole-manual]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #280:
URL: https://github.com/apache/guacamole-manual/pull/280#discussion_r2729871462
##########
src/openid-auth.md.j2:
##########
@@ -81,6 +81,72 @@ extension does not have priority:
extension-priority: *, openid
```
+(openid-single-logout)=
+
+### Single Logout (SLO)
+
+By default, logging out of Guacamole will only terminate the Guacamole session,
+leaving the user's session with the OpenID Connect identity provider intact. If
+the user logs back in without the identity provider session having expired,
+they will be automatically logged back in without needing to re-enter their
+credentials.
+
+To enable Single Logout, configure the `openid-logout-endpoint` property with
+the identity provider's logout endpoint. When configured, logging out of
+Guacamole will redirect the user to the identity provider's logout endpoint,
+terminating both the Guacamole session and the identity provider session.
+
+#### Single Logout configuration properties
+
+The following optional properties control Single Logout behavior:
+
+`openid-logout-endpoint`
+: The logout endpoint (URI) of the OpenID Connect identity provider. When
+ configured, users will be redirected to this endpoint when they log out from
+ Guacamole, allowing them to also log out from the identity provider. If not
+ set, logout will only terminate the Guacamole session.
+
+ For identity providers that implement OpenID Connect Discovery, this value can
+ be retrieved from the `end_session_endpoint` property of the JSON file hosted
+ at `https://identity-provider/.well-known/openid-configuration`.
+
+ This property can also be set using the `OPENID_LOGOUT_ENDPOINT` environment
+ variable.
+
+`openid-post-logout-redirect-uri`
+: The URI that the identity provider should redirect to after logout is
+ complete. If not specified, the value of `openid-redirect-uri` will be used as
+ the default.
+
+ This URI must be registered with your identity provider as an allowed
+ post-logout redirect URI.
+
+ This property can also be set using the `OPENID_POST_LOGOUT_REDIRECT_URI`
+ environment variable.
Review Comment:
I'm not sure you need to specifically document these properties, here - I think they will end up being pull in in the section, above, where the other optional properties get pulled in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-519: Openid Single Logout Docs [guacamole-manual]
Posted by "bayars (via GitHub)" <gi...@apache.org>.
bayars commented on code in PR #280:
URL: https://github.com/apache/guacamole-manual/pull/280#discussion_r2748767010
##########
src/openid-auth.md.j2:
##########
@@ -81,6 +81,44 @@ extension does not have priority:
extension-priority: *, openid
```
+(openid-single-logout)=
+
+### Single Logout (SLO)
+
+By default, logging out of Guacamole will only terminate the Guacamole session,
+leaving the user's session with the OpenID Connect identity provider intact. If
+the user logs back in without the identity provider session having expired,
+they will be automatically logged back in without needing to re-enter their
+credentials.
Review Comment:
I have pushed the fix. I used your words directly. Please review again @necouchman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-519: Openid Single Logout Docs [guacamole-manual]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #280:
URL: https://github.com/apache/guacamole-manual/pull/280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-519: Openid Single Logout Docs [guacamole-manual]
Posted by "bayars (via GitHub)" <gi...@apache.org>.
bayars commented on code in PR #280:
URL: https://github.com/apache/guacamole-manual/pull/280#discussion_r2729936631
##########
src/openid-auth.md.j2:
##########
@@ -81,6 +81,72 @@ extension does not have priority:
extension-priority: *, openid
```
+(openid-single-logout)=
+
+### Single Logout (SLO)
+
+By default, logging out of Guacamole will only terminate the Guacamole session,
+leaving the user's session with the OpenID Connect identity provider intact. If
+the user logs back in without the identity provider session having expired,
+they will be automatically logged back in without needing to re-enter their
+credentials.
+
+To enable Single Logout, configure the `openid-logout-endpoint` property with
+the identity provider's logout endpoint. When configured, logging out of
+Guacamole will redirect the user to the identity provider's logout endpoint,
+terminating both the Guacamole session and the identity provider session.
+
+#### Single Logout configuration properties
+
+The following optional properties control Single Logout behavior:
+
+`openid-logout-endpoint`
+: The logout endpoint (URI) of the OpenID Connect identity provider. When
+ configured, users will be redirected to this endpoint when they log out from
+ Guacamole, allowing them to also log out from the identity provider. If not
+ set, logout will only terminate the Guacamole session.
+
+ For identity providers that implement OpenID Connect Discovery, this value can
+ be retrieved from the `end_session_endpoint` property of the JSON file hosted
+ at `https://identity-provider/.well-known/openid-configuration`.
+
+ This property can also be set using the `OPENID_LOGOUT_ENDPOINT` environment
+ variable.
+
+`openid-post-logout-redirect-uri`
+: The URI that the identity provider should redirect to after logout is
+ complete. If not specified, the value of `openid-redirect-uri` will be used as
+ the default.
+
+ This URI must be registered with your identity provider as an allowed
+ post-logout redirect URI.
+
+ This property can also be set using the `OPENID_POST_LOGOUT_REDIRECT_URI`
+ environment variable.
Review Comment:
yes, good catch, thanks. I've removed the duplicate property documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-519: Openid Single Logout Docs [guacamole-manual]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #280:
URL: https://github.com/apache/guacamole-manual/pull/280#discussion_r2733568963
##########
src/openid-auth.md.j2:
##########
@@ -81,6 +81,44 @@ extension does not have priority:
extension-priority: *, openid
```
+(openid-single-logout)=
+
+### Single Logout (SLO)
+
+By default, logging out of Guacamole will only terminate the Guacamole session,
+leaving the user's session with the OpenID Connect identity provider intact. If
+the user logs back in without the identity provider session having expired,
+they will be automatically logged back in without needing to re-enter their
+credentials.
Review Comment:
Might be good to clarify this a little bit. something like:
```
If the user logs back in to Guacamole with the identity provider session having expired, they will be transparently logged in to Guacamole without needing to re-enter their credentials.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-519: Openid Single Logout Docs [guacamole-manual]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #280:
URL: https://github.com/apache/guacamole-manual/pull/280#discussion_r2733568963
##########
src/openid-auth.md.j2:
##########
@@ -81,6 +81,44 @@ extension does not have priority:
extension-priority: *, openid
```
+(openid-single-logout)=
+
+### Single Logout (SLO)
+
+By default, logging out of Guacamole will only terminate the Guacamole session,
+leaving the user's session with the OpenID Connect identity provider intact. If
+the user logs back in without the identity provider session having expired,
+they will be automatically logged back in without needing to re-enter their
+credentials.
Review Comment:
Might be good to clarify this a little bit. something like:
```
If the user logs back in to Guacamole without the identity provider session
having expired, they will be transparently logged in to Guacamole without
needing to re-enter their credentials.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org