[jira] [Commented] (HBASE-16133) RSGroupBasedLoadBalancer.retainAssignment() might miss a region

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359511#comment-15359511 ] 

Hudson commented on HBASE-16133:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #1150 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1150/])
HBASE-16133 RSGroupBasedLoadBalancer.retainAssignment() might miss a (enis: rev bc70dc00bb05580bdc597cedf152f8add1f48d90)
* hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java


> RSGroupBasedLoadBalancer.retainAssignment() might miss a region
> ---------------------------------------------------------------
>
>                 Key: HBASE-16133
>                 URL: https://issues.apache.org/jira/browse/HBASE-16133
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0
>
>         Attachments: hbase-16133_v1.patch
>
>
> We have seen in the tests through the IntegrationTestRSGroup that we may miss assigning a region. 
> It is a simple logic error here: 
> {code}
>         if (server != null && !assignments.containsKey(server)) {
>           assignments.put(server, new ArrayList<HRegionInfo>());
>         } else if (server != null) {
>            assignments.get(server).add(region);
>          } else {
> {code}
> in the first condition, we are not adding the region to the newly created ArrayList. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)